OpenStack notifications are enabled for Nova and Glance without Ceilometer

[Simon Pasquier]

Environment: Fuel 6.0 but the issue may exist on previous releases too.

On a newly created environment for which Ceilometer isn't enabled, notifications for the Nova and Glance services on the controller nodes are enabled. The notification.* queues are filling up constantly but no consumer reads from them.

# rabbitmqctl list_queues | grep notifications
notifications.info 20

I've spotted at least 2 pieces of code that enable notifications unconditionally:
- https://github.com/stackforge/fuel-library/blob/05e4b45cab29f6aff720436dda41c093a3be1260/deployment/puppet/openstack/manifests/nova/controller.pp#L246
- https://github.com/stackforge/fuel-library/blob/05e4b45cab29f6aff720436dda41c093a3be1260/deployment/puppet/glance/manifests/notify/rabbitmq.pp#L78

See also https://bugs.launchpad.net/nova/+bug/1188643 and the comment #10 from Doug for an explanation on why the queues are automatically created by the Oslo messaging notifier.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/161185

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/6.0
Review: https://review.openstack.org/162035

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.1
Review: https://review.openstack.org/162637

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/162035
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=18a71ce7b0c457b7f6539593be68f8e2cf758aa3
Submitter: Jenkins
Branch: stable/6.0

commit 18a71ce7b0c457b7f6539593be68f8e2cf758aa3
Author: Bartłomiej Piotrowski <email address hidden>
Date: Wed Mar 4 12:51:42 2015 +0100

    Disable notifications in Nova and Glance without Ceilometer

    Currently, even if Ceilomemter isn't enabled, notifications for the Nova
    and Glance services on the controller nodes are enabled. The notification.*
    queues are being filled up, but no consumer reads from them.

    Glance changes are taken from I3f2c29adbfb605ef288962f72ba81c11811cb35

    Change-Id: I00db51ceb4121e73bfe7e256b895e4fae122a496
    Closes-Bug: 1425982

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/161185
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=f7cea2502b8da64e7b5b64d15433012670f078a7
Submitter: Jenkins
Branch: master

commit f7cea2502b8da64e7b5b64d15433012670f078a7
Author: Bartłomiej Piotrowski <email address hidden>
Date: Wed Mar 4 12:51:42 2015 +0100

    Disable notifications in Nova and Glance without Ceilometer

    Currently, even if Ceilomemter isn't enabled, notifications for the Nova
    and Glance services on the controller nodes are enabled. The notification.*
    queues are being filled up, but no consumer reads from them.

    Glance changes are taken from I3f2c29adbfb605ef288962f72ba81c11811cb35

    Change-Id: I00db51ceb4121e73bfe7e256b895e4fae122a496
    Closes-Bug: 1425982

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/162637
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=5980394bf04bae78562494c66232fc72f4d0af98
Submitter: Jenkins
Branch: stable/5.1

commit 5980394bf04bae78562494c66232fc72f4d0af98
Author: Bartłomiej Piotrowski <email address hidden>
Date: Wed Mar 4 12:51:42 2015 +0100

    Disable notifications in Nova and Glance without Ceilometer

    Currently, even if Ceilomemter isn't enabled, notifications for the Nova
    and Glance services on the controller nodes are enabled. The notification.*
    queues are being filled up, but no consumer reads from them.

    Glance changes are taken from I3f2c29adbfb605ef288962f72ba81c11811cb35

    Change-Id: I00db51ceb4121e73bfe7e256b895e4fae122a496
    Closes-Bug: 1425982

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/165081

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/165081
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=690543dcf80120e0975ee1d8b4c38d071ba71893
Submitter: Jenkins
Branch: master

commit 690543dcf80120e0975ee1d8b4c38d071ba71893
Author: Bartłomiej Piotrowski <email address hidden>
Date: Tue Mar 17 15:02:36 2015 +0100

    Pass $ceilometer to openstack::glance and openstack::controller

    Commit I00db51ceb4121e73bfe7e256b895e4fae122a496 added possibility to
    control whether Ceilometer notifications are sent, but didn't add
    appropriate parameter to higher level classes, making notifications
    disabled even if Ceilometer is enabled.

    Additionally backport I3f2c29adbfb605ef288962f72ba81c11811cb357 to
    glance module.

    Change-Id: I2db7c13cd9c59e29e42e5000961eeedc6717e1ee
    Closes-Bug: 1433075
    Related-Bug: 1425982

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/6.0
Review: https://review.openstack.org/167127

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/5.1
Review: https://review.openstack.org/167128

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167127
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=847200e5e6830a9e57cc73e5783ad3a9469407fe
Submitter: Jenkins
Branch: stable/6.0

commit 847200e5e6830a9e57cc73e5783ad3a9469407fe
Author: Bartłomiej Piotrowski <email address hidden>
Date: Tue Mar 17 15:02:36 2015 +0100

    Pass $ceilometer to openstack::glance and openstack::controller

    Commit I00db51ceb4121e73bfe7e256b895e4fae122a496 added possibility to
    control whether Ceilometer notifications are sent, but didn't add
    appropriate parameter to higher level classes, making notifications
    disabled even if Ceilometer is enabled.

    Additionally backport I3f2c29adbfb605ef288962f72ba81c11811cb357 to
    glance module.

    Change-Id: I2db7c13cd9c59e29e42e5000961eeedc6717e1ee
    Closes-Bug: 1433075
    Related-Bug: 1425982

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167128
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=04d9daf599fd2a4feb9ae8770fe8ecaca34b114e
Submitter: Jenkins
Branch: stable/5.1

commit 04d9daf599fd2a4feb9ae8770fe8ecaca34b114e
Author: Bartłomiej Piotrowski <email address hidden>
Date: Tue Mar 17 15:02:36 2015 +0100

    Pass $ceilometer to openstack::glance and openstack::controller

    Commit I00db51ceb4121e73bfe7e256b895e4fae122a496 added possibility to
    control whether Ceilometer notifications are sent, but didn't add
    appropriate parameter to higher level classes, making notifications
    disabled even if Ceilometer is enabled.

    Additionally backport I3f2c29adbfb605ef288962f72ba81c11811cb357 to
    glance module.

    Change-Id: I2db7c13cd9c59e29e42e5000961eeedc6717e1ee
    Closes-Bug: 1433075
    Related-Bug: 1425982

[Anastasia Palkina (apalkina)]

Verified on ISO #394 for CentOS and Ubuntu

"build_id": "2015-05-08_10-07-32", "build_number": "394", "release_versions": {"2014.2.2-6.1": {"VERSION": {"build_id": "2015-05-08_10-07-32", "build_number": "394", "api": "1.0", "fuel-library_sha": "f385d6a58298c702f8d4f14c452dcffdc0b1e2a3", "nailgun_sha": "46f55c293e4540d31bcaa6ca3fba77235fb27537", "feature_groups": ["mirantis"], "openstack_version": "2014.2.2-6.1", "production": "docker", "python-fuelclient_sha": "af6c9c3799b9ec107bcdc6dbf035cafc034526ce", "astute_sha": "6a4dcd11c67af2917815f3678fb594c7412a4c97", "fuel-ostf_sha": "740ded337bb2a8a9b3d505026652512257375c01", "release": "6.1", "fuelmain_sha": "3eca5e8f7ca6a83faff5feeca92c21cff31c0af1"}}}, "auth_required": true, "api": "1.0", "fuel-library_sha": "f385d6a58298c702f8d4f14c452dcffdc0b1e2a3", "nailgun_sha": "46f55c293e4540d31bcaa6ca3fba77235fb27537", "feature_groups": ["mirantis"], "openstack_version": "2014.2.2-6.1", "production": "docker", "python-fuelclient_sha": "af6c9c3799b9ec107bcdc6dbf035cafc034526ce", "astute_sha": "6a4dcd11c67af2917815f3678fb594c7412a4c97", "fuel-ostf_sha": "740ded337bb2a8a9b3d505026652512257375c01", "release": "6.1", "fuelmain_sha": "3eca5e8f7ca6a83faff5feeca92c21cff31c0af1"