6 defects installing MOS 5.1 on Windows 8 for Virtual Box

[Roman Rufanov]

Config:
* Windows 8
* CygWin 64
* Virtual Box 4.3.12

I tried to install MOS 5.1 on Windows 8 - and there were 6 defects which prevented this.

1. There are syntax errors in the memory.sh script.
File: memory.sh

From: elif [ $(which top) != '' ]; then
To: elif [ "$(which top)" != "" ]; then

2. memory.sh script is trying to use TOP and FREE commands - both are not available in CygWin by default. In this case default value is used and it is set to -1. This is not reasonable default for Windows machine. It would be better to use 4GB as example.

From:
    else
      total_memory="-1"
    fi

To:
    else
      total_memory="4000000"
    fi

3. Why the default is used at all when I run the script ./launch_4GB.sh ?
In this case it would be better not to determine memory and just use the number provided by user. I already select that I have 4GB by running launch_4GB.sh script.

4. To install TOP and FREE "procps" package is needed.
It would be nice if error from script failed with clear message: "TOP and FREE not found on CygWin . Please install procps package"

5. After CygWin install the path there looks like this.
It would be nice if scripts adds standart path to PATH variable.
99% of users will be spared from manually chaging this path.
export PATH=.:$PATH:/cygdrive/c/Windows/system32:/cygdrive/c/Windows/System32/Wbem:

6. Once MOS is installed and Virtual Box is shutdown - all VMs disappear when you restart it.
I had to do "Machine - > add" for very VM.
I suspect this is because default path to VM location contains space.

Thanks, Roman R

[Mike Scherbakov (mihgen)]

Roman,
thank you for detailed analysis and troubleshooting. We will address these issues.

[Roman Alekseenkov (ralekseenkov)]

I think we are trying to be too smart here. If user is using a template (let's say 16GB), may be we should let him do it without any additional checks on available memory...

Using 'top' and 'free' is nice, but we are overcomplicating everything and this is causing issues in the field.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/124757

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/124757
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=7c98912407dce20dbef759fb19719b79b4a627d2
Submitter: Jenkins
Branch: master

commit 7c98912407dce20dbef759fb19719b79b4a627d2
Author: Dmitry Tyzhnenko <email address hidden>
Date: Mon Sep 29 17:34:47 2014 +0300

    Changes to improve work under windows

    Added check for procps in prepare-environment
    Available memory check moved to separate action
    Added requirements section in README
    Fixed top and free check in Cygwin

    Change-Id: I2e700602fe7bb81464975521023f4693462b4379
    Closes-Bug: #1373655

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/135926

[OpenStack Infra (hudson-openstack)]

Change abandoned by Serhiy Ovsianikov (<email address hidden>) on branch: master
Review: https://review.openstack.org/135926
Reason: error branch

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/135932

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.1
Review: https://review.openstack.org/135936

[OpenStack Infra (hudson-openstack)]

Change abandoned by Serhiy Ovsianikov (<email address hidden>) on branch: master
Review: https://review.openstack.org/135932
Reason: error branch

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.1
Review: https://review.openstack.org/136190

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Borodaenko (<email address hidden>) on branch: stable/5.1
Review: https://review.openstack.org/135936
Reason: Resubmitted with fixed Change-Id in https://review.openstack.org/136190

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/136190
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=4e62ea7e8922fdc438a91476e5d5be2d05eb71c6
Submitter: Jenkins
Branch: stable/5.1

commit 4e62ea7e8922fdc438a91476e5d5be2d05eb71c6
Author: Dmitry Tyzhnenko <email address hidden>
Date: Mon Sep 29 17:34:47 2014 +0300

    Changes to improve work under windows

    Added check for procps in prepare-environment
    Available memory check moved to separate action
    Added requirements section in README
    Fixed top and free check in Cygwin

    Closes-Bug: #1373655

    Change-Id: I2e700602fe7bb81464975521023f4693462b4379
    (cherry picked from commit 7c98912407dce20dbef759fb19719b79b4a627d2)