[cli] Fuel deploy-changes in the valid case output traceback

Bug #1330485 reported by Egor Kotko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Dima Shulyak
5.0.x
Fix Committed
High
Dima Shulyak

Bug Description

{"build_id": "2014-06-16_00-31-15", "mirantis": "yes", "build_number": "255", "ostf_sha": "67b61ed3788297fa5d985afec32498d8c0f812db", "nailgun_sha": "984aa7a86487f1488c2f83c052904abd9f589b7f", "production": "docker", "api": "1.0", "fuelmain_sha": "6f355160366475d52050d7898a1080a95ecb9cbf", "astute_sha": "17b1afa5f0dc8f4fca5ed4eb03ec566fbfb5ed19", "release": "5.1", "fuellib_sha": "99d74172887ab81d38132655d6e5d180e8726437"}

Steps to reproduce:

#fuel env create --name=test --mode=ha --network-mode neutron --net-segment-type gre --rel=1
#fuel node -s --env 4 --node-id=6 --role=controller
#fuel deploy-changes --env 4

Expected result:
Progress of provisioning and deployment

Actual result:
Traceback (most recent call last):
  File "/usr/bin/fuel", line 9, in <module>
    load_entry_point('fuelclient==0.2', 'console_scripts', 'fuel')()
  File "/usr/lib/python2.6/site-packages/fuelclient/cli/error.py", line 95, in wrapper
    handle_exceptions(exc)
  File "/usr/lib/python2.6/site-packages/fuelclient/cli/error.py", line 93, in wrapper
    return func(*args, **kwargs)
  File "/usr/lib/python2.6/site-packages/fuelclient/cli/parser.py", line 148, in main
    parser.parse()
  File "/usr/lib/python2.6/site-packages/fuelclient/cli/parser.py", line 80, in parse
    actions[parsed_params.action].action_func(parsed_params)
  File "/usr/lib/python2.6/site-packages/fuelclient/cli/actions/base.py", line 53, in action_func
    method(params)
  File "/usr/lib/python2.6/site-packages/fuelclient/cli/actions/deploy.py", line 46, in deploy_changes
    print_method=print_deploy_progress)
  File "/usr/lib/python2.6/site-packages/fuelclient/cli/serializers.py", line 66, in print_to_output
    print_method(arg.encode('utf-8'))
AttributeError: 'DeployTask' object has no attribute 'encode'

Tags: cli
Revision history for this message
Egor Kotko (ykotko) wrote :
Changed in fuel:
importance: Low → Medium
assignee: nobody → Fuel Python Team (fuel-python)
summary: - cli. Fuel deploy-changes in the valid case output traceback
+ [cli] Fuel deploy-changes in the valid case output traceback
Dima Shulyak (dshulyak)
Changed in fuel:
status: New → Confirmed
Revision history for this message
Dima Shulyak (dshulyak) wrote :

it will fail on any deploy-changes call or fuel --env 1 health --check call, raising this to High

Changed in fuel:
importance: Medium → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/100482

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Dima Shulyak (dshulyak)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/100482
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=64565eda1b19532571ed66fcc120c8f824db2272
Submitter: Jenkins
Branch: master

commit 64565eda1b19532571ed66fcc120c8f824db2272
Author: Dima Shulyak <email address hidden>
Date: Tue Jun 17 13:10:14 2014 +0300

    Encode should be called only for strings

    If not string provided as arg to print_to_output
    it should not be encoded, and lets assume that proper unicode handling
    will be done in custom print_method

    Change-Id: If0c03571ccc7513fe85c38477ad9750ad9d82e97
    Closes-Bug: #1330485

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/5.0)

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/111195

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/5.0)

Reviewed: https://review.openstack.org/111195
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=4ddf2faf88989976cbd328aca4c8743aae0f317f
Submitter: Jenkins
Branch: stable/5.0

commit 4ddf2faf88989976cbd328aca4c8743aae0f317f
Author: Dima Shulyak <email address hidden>
Date: Tue Jun 17 13:10:14 2014 +0300

    Encode should be called only for strings

    If not string provided as arg to print_to_output
    it should not be encoded, and lets assume that proper unicode handling
    will be done in custom print_method

    Change-Id: If0c03571ccc7513fe85c38477ad9750ad9d82e97
    Closes-Bug: #1330485

Egor Kotko (ykotko)
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.