Override_resources is unable to remove customized parameters

[Alexander Rubtsov]

--- Environment ---
MOS: 9.2

--- Description ---
The override_resources feature (https://docs.mirantis.com/fuel-docs/mitaka/userdocs/fuel-user-guide/cli/cli_config_openstack.html) enables to add a new parameter / change the value of a parameter.
However as soon as the customized value has been uploaded, it can not be removed by override_resources means (i.e. reverted to initial value).

--- Steps to reproduce ---
1. Deploy an environment
2. Create the following /root/nova.yaml file on the Fuel node:
configuration:
  nova_config:
    DEFAULT/verbose:
      value: 'True'

3. Upload the configuration:
fuel openstack-config --env 1 --upload --file nova.yaml

4. Download the changed configuration:
fuel deployment --env 1 --default

5. Ensure that the modified value is in place:
grep -r "verbose" -A1 /root/deployment_1/
/root/deployment_1/2.yaml: DEFAULT/verbose:
/root/deployment_1/2.yaml- value: 'True'
--
/root/deployment_1/3.yaml: DEFAULT/verbose:
/root/deployment_1/3.yaml- value: 'True'

6. Remove the parameter from the /root/nova.yaml file:
configuration:
  nova_config:
# DEFAULT/verbose:
# value: 'True'

7. Upload the changes
fuel openstack-config --env 1 --upload --file nova.yaml

8. Download the changed configuration:
fuel deployment --env 1 --default

9. Verify the current value of the parameter:
grep -r "verbose" -A1 /root/deployment_1/

--- Actual behavior ---
The modified value is still here
/root/deployment_1/2.yaml: DEFAULT/verbose:
/root/deployment_1/2.yaml- value: 'True'
--
/root/deployment_1/3.yaml: DEFAULT/verbose:
/root/deployment_1/3.yaml- value: 'True'

--- Expected behavior ---
There are no modifications

[Alexander Rubtsov (arubtsov)]

sla2 for 9.0-updates

[Alexander Rubtsov (arubtsov)]

Hello, do you have any updates regarding this matter?

[Roman Lubianyi (rlubianyi)]

Hello Alexander,
We have identified an issue:
When you apply or download configuration with removed parameter fuel cli didn't check "is_active" flag in the openstack_configs table. Currently, we are working on the patch for this issue.

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: 9.0/mitaka
Change author: Oleksiy Molchanov <email address hidden>
Review: https://review.fuel-infra.org/40680

[Oleksiy Molchanov (omolchanov)]

Alexander, you need to identify and delete config you have added

fuel openstack-config --list --env ID
fuel openstack-config --delete --config CONF_ID

PS: patch should be applied with nailgun service restart

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/40680
Submitter: Pkgs Jenkins <email address hidden>
Branch: 9.0/mitaka

Commit: 3042a396968f4741a8554ef31255d95a45041772
Author: Oleksiy Molchanov <email address hidden>
Date: Fri Mar 1 10:26:55 2019

Add to deployment custom configs that are active

Closes-Bug: 1814550
Change-Id: If3326434373251aaa935fc449d065cacce9eb567

[Pavel Glazov (pglazovv)]

Verified:
[root@nailgun ~]# vim /root/nova.yaml
[root@nailgun ~]# fuel openstack-config --env 1 --upload --file nova.yaml
id | is_active | config_type | cluster_id | node_id | node_role
---+-----------+-------------+------------+---------+----------
1 | True | cluster | 1 | |
[root@nailgun ~]# fuel deployment --env 1 --default
Default deployment info was downloaded to /root/deployment_1
[root@nailgun ~]# grep -r "verbose" -A1 /root/deployment_1/
/root/deployment_1/6.yaml: DEFAULT/verbose:
/root/deployment_1/6.yaml- value: 'True'
--
/root/deployment_1/5.yaml: DEFAULT/verbose:
/root/deployment_1/5.yaml- value: 'True'
--
/root/deployment_1/3.yaml: DEFAULT/verbose:
/root/deployment_1/3.yaml- value: 'True'
--
/root/deployment_1/2.yaml: DEFAULT/verbose:
/root/deployment_1/2.yaml- value: 'True'
--
/root/deployment_1/4.yaml: DEFAULT/verbose:
/root/deployment_1/4.yaml- value: 'True'
--
/root/deployment_1/1.yaml: DEFAULT/verbose:
/root/deployment_1/1.yaml- value: 'True'
[root@nailgun ~]# vim /root/nova.yaml
[root@nailgun ~]# fuel openstack-config --env 1 --upload --file nova.yaml
id | is_active | config_type | cluster_id | node_id | node_role
---+-----------+-------------+------------+---------+----------
2 | True | cluster | 1 | |
[root@nailgun ~]# fuel deployment --env 1 --default
Default deployment info was downloaded to /root/deployment_1
[root@nailgun ~]# grep -r "verbose" -A1 /root/deployment_1/
[root@nailgun ~]#