Deployment sequences as graph seem to have issues with package update

[Vladimir Kuklin]

Here https://ci.fuel-infra.org/job/master.fuel-library.pkgs.ubuntu.smoke_neutron we can see that all jobs since 9715 are Red with the issue raised onto deployment tasks upload on fuel library package installation with something like this in the logs:

IntegrityError: (psycopg2.IntegrityError) duplicate key value violates unique constraint "_task_name_deployment_graph_id_uc"
DETAIL: Key (deployment_graph_id, task_name)=(1, generate_vms) already exists.

It looks like that we upload a graph with duplicate tasks. It seems to happen due to the following line in the fuel library spec:

ln -sf /etc/puppet/modules /etc/fuel/graphs/deploy

Which runs multiply times on package update. This creates redundant symlinks and thus tasks are concatenated twice.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/441704

[Vladimir Kuklin (vkuklin)]

Yeah, I can confirm that - we create 'modules' symlink in /etc/puppet/modules which points to /etc/puppet/modules/ thus, we have 2 copies of tasks being uploaded at the same time to the API

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/441704
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=a646ae6a131fa15fc77b6497f1b7f918656fee8b
Submitter: Jenkins
Branch: master

commit a646ae6a131fa15fc77b6497f1b7f918656fee8b
Author: Vladimir Kuklin <email address hidden>
Date: Sun Mar 5 22:42:33 2017 +0300

    Make tasks upload on package upgrade idempotent

    Previously, we were creating the symlink for default
    deployment graph without unlinking it. This creates
    second symlink within /etc/fuel/graphs/deploy
    directory

    Rename deploy graph to `default` to comply with plugins

    Change-Id: I0769dc84c38759aab6ef9288c00fb2dda40add7f
    Closes-bug: #1670182

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/442441

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/442441
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=21a29ebbede160a78aca96fa3fa0432f209ba17e
Submitter: Jenkins
Branch: stable/ocata

commit 21a29ebbede160a78aca96fa3fa0432f209ba17e
Author: Vladimir Kuklin <email address hidden>
Date: Sun Mar 5 22:42:33 2017 +0300

    Make tasks upload on package upgrade idempotent

    Previously, we were creating the symlink for default
    deployment graph without unlinking it. This creates
    second symlink within /etc/fuel/graphs/deploy
    directory

    Rename deploy graph to `default` to comply with plugins

    Change-Id: I0769dc84c38759aab6ef9288c00fb2dda40add7f
    Closes-bug: #1670182
    (cherry picked from commit a646ae6a131fa15fc77b6497f1b7f918656fee8b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-library 11.0.0.0rc2 release candidate.