Do not install Docker

[Alexander Rubtsov]

MOS: 9.2

As Docker containers are not used anymore in MOS 9.2 it would make sense to prevent Docker packages to be installed to the Fuel master node at all in order to secure the node and simplify the further maintenance process

[root@fuel ~]# ps aux | grep docker
root 30710 0.0 0.0 112648 968 pts/0 S+ 08:45 0:00 grep --color=auto docker

--- Actual result ---
[root@fuel ~]# service docker status
Redirecting to /bin/systemctl status docker.service
● docker.service - Docker Application Container Engine
   Loaded: loaded (/usr/lib/systemd/system/docker.service; disabled; vendor preset: disabled)
   Active: inactive (dead)

[root@fuel ~]# rpm -qa | grep "docker"
docker-selinux-1.10.3-46.el7.centos.14.x86_64
docker-common-1.10.3-46.el7.centos.14.x86_64
docker-1.10.3-46.el7.centos.14.x86_64

--- Expected result ---
[root@fuel ~]# service docker status
Redirecting to /bin/systemctl status docker.service
● docker.service
   Loaded: not-found (Reason: No such file or directory)
   Active: inactive (dead)

[root@fuel ~]# rpm -qa | grep "docker"
[root@fuel ~]#

[Alexander Rubtsov (arubtsov)]

sla1 for 9.0-updates

[Dmitry Pyzhov (dpyzhov)]

We don't use docker so we shouldn't install it the first place. However we cannot delete in during update because some customers are use it. So let's stop installing it in new versions and not backport the fix.

[Dmitry Pyzhov (dpyzhov)]

Let's remove docker installation for 9.x updates too.

[Alexander Rubtsov (arubtsov)]

sla2 for 9.0-updates

[Georgy Kibardin (gkibardin)]

Invalid for 9.x
We use 9.0 ISO which already contains docker and upgrade it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/444793

[Georgy Kibardin (gkibardin)]

In order to get rid of docker in 9x we need to change update scripts so that it deletes docker package.

[Valeriy Saharov (vsakharov)]

It will be good to see the backport of this commit from master to the stable/mitaka branch, because our customer is using 9.x isos. This changes should not affect other customers, because during the upgrading procedure bootstrap_admin_node.sh don't use.

[Georgy Kibardin (gkibardin)]

It is not a backport, Docker is already on 9.0 ISO. In order to get rid of it we need to add line to update scripts to remove the package.

[Alexey Stupnikov (astupnikov)]

I think that Valeriy is talking about E/// builds.

But what is the point behind docker deletion? Does docker bring something bad to the installation or breaks something for the customers?

[Alexey Stupnikov (astupnikov)]

BTW, something is wrong with this bug's nominations. Georgy pushed a patch for master branch, but there is no such kind of milestone in bug's nominations.

[Denis Meltsaykin (dmeltsaykin)]

This solution is neither acceptable nor desirable, at least for the following reasons:

 * Docker is still being actively used in 9.x for cloud validation
 * It hasn't been properly deprecated with a wide announcement in 8.0
 * There is a probability that it's needed for 3rd-party tools
 * It doesn't fit the Maintenance Policy (functional changes not fixing issues are prohibited)

Keeping in mind all the above and that disadvantages of the docker removal outweigh its possible advantages, I'm going to close this report as Won't Fix in the 9.x series.

[Georgy Kibardin (gkibardin)]

Before getting rid of Docker on the master node we need to do something with tests which expect docker on master node. Probably these test must install it before run.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Andreas Jaeger (<email address hidden>) on branch: master
Review: https://review.opendev.org/444793
Reason: This repo is retired now, no further work will get merged.