telemetry plugin does not honor rabbitmq decompose

[Dmitry Sutyagin]

Reproduced in MOS 9.2 + telemetry plugin 1.0 + StackLight plugins 1.0

Steps to reproduce:
- have 9.2 with telemetry plugin + StackLight plugins 1.0
- decompose rabbitmq role and set to deploy it on separate nodes (from controllers)
- deploy

Expected result:
- Deployment succeeded

Actual result:
 - Deployment has failed. All nodes are finished. Failed tasks: Task[telemetry-heka/21] Stopping the deployment process!

telemetry-heka failed because crm resource clone_p_telemetry-collector-heka cannot start.
telemetry-collector-heka cannot start because it cannot connect to amqp, because in it's config
/etc/telemetry-collector-heka/amqp-openstack_sample.toml the IP of RabbitMQ server is local management IP of the controller, and not any of the decomposed RabbitMQ nodes.

[Dmitry Sutyagin (dsutyagin)]

Same issue if Standalone RabbitMQ plugin is used

[Dmitry Sutyagin (dsutyagin)]

Workaround is to live-patch the config /etc/telemetry-collector-heka/amqp-openstack_sample.toml while telemetry-heka task is running, setting correct IP there. If this is done in time, task does not fail and deployment finishes successfully.

[Dmitry Sutyagin (dsutyagin)]

This part of the plugin has to be reworked - https://github.com/openstack/fuel-plugin-openstack-telemetry/blob/master/deployment_scripts/puppet/manifests/hiera.pp#L104

[Denis Meltsaykin (dmeltsaykin)]

Dmitry, if you'll keep self-confirming bugs you won't get any result. Please don't skip the confirmation procedure, which is essential for bug to be assigned to a proper team.

[Dmitry Sutyagin (dsutyagin)]

My bad!

Anyway, the proposed fix is https://review.openstack.org/#/c/438931/, but I feel like it's incorrect, I will need to test it. For customer we made a different fix by taking some code from detached-rabbitmq plugin manifest to extract IPs of rabbitmq nodes.

[Oleksiy Molchanov (omolchanov)]

Dmitry, are you okay with existing patch? Seems that a proper solution is a feature request.

[Dmitry Sutyagin (dsutyagin)]

The provided patch is useless, no need to merge it. Im ok if this gets a "won't fix".