Unused nodes in Custom Workflow constantly show 1% of progress

[Ekaterina Khomyakova]

Fuel 10 #1355

Steps to reproduce:
  1. Log in to Fuel UI
  2. Add 1 controller and 1 compute nodes
  3. Provision nodes
  4. Go to Workflows tab and add custom workflow from json file where there is no "compute" in "groups" section
  5. Run custom workflow on nodes
  6. Go to Nodes tab

Expected results:
  Compute node is in provisioned (or ready?) state

Actual result:
  Compute shows progress 1% (see attached picture)

Example of json config:

[
  {
    "version": "1.0.0",
    "id": "task_1",
    "task_name": "task_1",
    "type": "shell",
    "parameters": {
      "cmd": "sleep 10",
      "timeout": 100
    },
    "groups": [
      "primary-controller",
      "controller"
    ]
  }
]

[Vladimir Kuklin (vkuklin)]

We set node progress to 1 when we start the deployment, but we do not set it to 100 if the node has no tasks to run. We do not now which particular node have 0 tasks as graph serialization runs right before casting the message to Astute. This should be fixed on Astute size by sending node progress set to 100 for the nodes that do not have any tasks to run.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/450814

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/450814
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=e4290053d9623c332831e6b546355dccb5731c5b
Submitter: Jenkins
Branch: stable/newton

commit e4290053d9623c332831e6b546355dccb5731c5b
Author: Vladimir Kozhukalov <email address hidden>
Date: Tue Mar 28 17:22:57 2017 +0300

    Set empty list of tasks by default

    If a graph does not assume running any tasks on some nodes,
    these nodes will hang on 1% progress forever because astute
    just knows nothing about these nodes and thus is unable to
    send any report about these nodes.

    Change-Id: Id8f2f8112720180e13193d70b47c88c3106ffe6f
    Closes-Bug: #1666192

[TatyanaGladysheva (tgladysheva)]

Verified on 10.0 build #1569.