fuel2 role create command has unclear syntax

[Ilya Bumarskov]

The first problem is incorrect help message:

[root@nailgun ~]# fuel2 role create
usage: fuel2 role create [-h] -r RELEASE -n NAME -f {json,yaml} [-d DIRECTORY]
fuel2 role create: error: argument -r/--release is required

Argument "-n" is used for determining FILE, not for a NAME of new role. The name of new role is described in a file and can be different from filename.

The second problem related with mandatory argument "-f". It adds specified extension to the filename. For example, we have file "/tmp/create_role.yaml" and we want to apply it:

[root@nailgun ~]# fuel2 role create -n /tmp/create_role.yaml -r 2 -f yaml
Could not read description for role '/tmp/create_role.yaml' at /tmp/create_role.yaml.yaml

As you can see, argument "-f" adds a specified extension to the file name and it's can confuse user.

[Ilya Bumarskov (ibumarskov)]

It seems I used command incorrectly. Right way:

[root@nailgun ~]# fuel2 role create -n reate_role -r 2 -f yaml -d /tmp

But anyway in such case we have to upload our file with role in specific folder: release_{release_number}/{role_name}.yaml
We should describe it in help message.

[Vitalii Kulanov (vitaliy-t)]

@Ilya,

What is your proposition about 'fuel2 role create' command help. Actually, in fuelclient, we have several commands with exact the same behavior as for the 'role create' command. Currently help message looks like as follows:

[root@fuel ~]# fuel2 role create --help
usage: fuel2 role create [-h] (-r RELEASE | -e ENV) -n NAME -f {json,yaml}
                         [-d DIRECTORY]

Create a role from file description

optional arguments:
  -h, --help show this help message and exit
  -r RELEASE, --release RELEASE
                        Id of the release
  -e ENV, --env ENV Id of the environment
  -n NAME, --name NAME Name of role.
  -f {json,yaml}, --format {json,yaml}
                        Format of serialized role description.
  -d DIRECTORY, --directory DIRECTORY
                        Source directory. Defaults to the current directory.