Limits task not triggered during deploy

Bug #1659351 reported by Oleksiy Molchanov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Critical
Vladimir Kuklin
Mitaka
Fix Released
Critical
Oleksiy Molchanov
Newton
Fix Released
Critical
Oleksiy Molchanov
Ocata
Fix Committed
Critical
Vladimir Kuklin

Bug Description

Limits task is not triggered on deployment. We should update yaql:

(($.get('limits', None) = None) and ($.deployed_before.value = false)) or changed($.get('limits'))

Verification steps:
https://bugs.launchpad.net/fuel/+bug/1644318

Changed in fuel:
milestone: none → 11.0
assignee: nobody → Fuel Sustaining (fuel-sustaining-team)
importance: Undecided → Medium
status: New → Confirmed
tags: added: area-library
Revision history for this message
Vladimir Kuklin (vkuklin) wrote :

This issue seems to be critical as it is a major regression which will lead to severe performance and scale issues for services.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/425679

Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Oleksiy Molchanov (omolchanov)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/425680

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/425681

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/426234

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/mitaka)

Reviewed: https://review.openstack.org/425681
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=238127b5b4ee80de1f5ab49cf423cfed3281392d
Submitter: Jenkins
Branch: stable/mitaka

commit 238127b5b4ee80de1f5ab49cf423cfed3281392d
Author: Oleksiy Molchanov <email address hidden>
Date: Thu Jan 26 15:12:05 2017 +0200

    Update limits

    * Update yaql expression for limits task
    * Move libvirtd limits to compute task

    Change-Id: I314fdf80c11fe81e158b65f3df1732bc7ba75195
    Closes-Bug: 1659351

tags: added: on-verification
Revision history for this message
Nastya Urlapova (aurlapova) wrote :

Dev team, could you please update description, original description is absolutely understandable for repro.

tags: removed: on-verification
tags: added: dev-to-verify
Revision history for this message
Nastya Urlapova (aurlapova) wrote :

After update of description, I'll remove tag "dev-to-verify"

description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (master)

Change abandoned by Oleksiy Molchanov (<email address hidden>) on branch: master
Review: https://review.openstack.org/425679

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (stable/newton)

Change abandoned by Oleksiy Molchanov (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/425680

Revision history for this message
Ilya Bumarskov (ibumarskov) wrote :

Verified on snapshot-id #822
controller:
root@node-1:~# ulimit -n
102400

compute, cinder:
root@node-4:~# ulimit -n
102400
root@node-4:~# cat /etc/init/libvirtd.conf | grep limit
limit nofile 102400 102400

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/433089

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/433090

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/443582

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/433089
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=e4a035a3d59d6ccf26db1c47abf0a3c9a6b7c19c
Submitter: Jenkins
Branch: master

commit e4a035a3d59d6ccf26db1c47abf0a3c9a6b7c19c
Author: Oleksiy Molchanov <email address hidden>
Date: Fri Jan 27 15:47:56 2017 +0200

    Update yaql for limits and fix typo

    Change-Id: I9dad36d22248e6e2b2936e32931c31f7a13bed83
    Closes-Bug: 1659351

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/newton)

Reviewed: https://review.openstack.org/433090
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=3a8a7c0ac8c6557fbea854aecdc7f6e75c40f56b
Submitter: Jenkins
Branch: stable/newton

commit 3a8a7c0ac8c6557fbea854aecdc7f6e75c40f56b
Author: Oleksiy Molchanov <email address hidden>
Date: Fri Jan 27 15:47:56 2017 +0200

    Update yaql for limits and fix typo

    Change-Id: I9dad36d22248e6e2b2936e32931c31f7a13bed83
    Closes-Bug: 1659351

Revision history for this message
Ekaterina Shutova (eshutova) wrote :

Verified on 10.1 #1566.
controller:
root@node-2:~# ulimit -n
102400
compute:
root@node-5:~# ulimit -n
102400
root@node-5:~# cat /etc/init/libvirtd.override | grep limit
limit nofile 102400 102400

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (stable/ocata)

Change abandoned by Andreas Jaeger (<email address hidden>) on branch: stable/ocata
Review: https://review.opendev.org/443582
Reason: This repo is retired now, no further work will get merged.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.