Incorrect cobbler's logrotate configuration
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Fuel for OpenStack |
High
|
MOS Linux | ||
| Mitaka |
High
|
MOS Linux | ||
| Newton |
High
|
MOS Linux | ||
| Ocata |
High
|
MOS Linux |
Bug Description
There is incorrect postrotate script in /etc/logrotate.
postrotate
if [ -f /var/lock/
fi
endscript
It looks like we need to use another approach to restart cobblerd after logs are rotated.
Affected packages:
- cobbler-
- cobbler-
description: | updated |
Vitaly Sedelnik (vsedelnik) wrote : | #1 |
Changed in fuel: | |
status: | New → Incomplete |
assignee: | MOS Linux (mos-linux) → Alexey Stupnikov (astupnikov) |
Alexey Stupnikov (astupnikov) wrote : | #2 |
We switched from init scripts to systemd. There is no /etc/init.
[root@localhost ~]# /etc/init.
-bash: /etc/init.
Alexey Stupnikov (astupnikov) wrote : | #3 |
Moving back to Confirmed, assigning to linux team.
Changed in fuel: | |
status: | Incomplete → Confirmed |
assignee: | Alexey Stupnikov (astupnikov) → MOS Linux (mos-linux) |
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/centos7/cobbler (9.0) | #4 |
Fix proposed to branch: 9.0
Change author: Ivan Suzdal <email address hidden>
Review: https:/
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/centos7/cobbler (10.0/newton) | #5 |
Fix proposed to branch: 10.0/newton
Change author: Ivan Suzdal <email address hidden>
Review: https:/
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/centos7/cobbler (master) | #6 |
Fix proposed to branch: master
Change author: Ivan Suzdal <email address hidden>
Review: https:/
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on packages/centos7/cobbler (10.0/newton) | #7 |
Change abandoned by Ivan Suzdal <email address hidden> on branch: 10.0/newton
Review: https:/
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change restored on packages/centos7/cobbler (10.0/newton) | #8 |
Change restored by Ivan Suzdal <email address hidden> on branch: 10.0/newton
Review: https:/
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on packages/centos7/cobbler (9.0) | #9 |
Change abandoned by Ivan Suzdal <email address hidden> on branch: 9.0
Review: https:/
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change restored on packages/centos7/cobbler (9.0) | #10 |
Change restored by Ivan Suzdal <email address hidden> on branch: 9.0
Review: https:/
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on packages/centos7/cobbler (10.0/newton) | #11 |
Change abandoned by Ivan Suzdal <email address hidden> on branch: 10.0/newton
Review: https:/
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/centos7/cobbler (10.0/newton) | #12 |
Fix proposed to branch: 10.0/newton
Change author: Ivan Suzdal <email address hidden>
Review: https:/
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on packages/centos7/cobbler (10.0/newton) | #13 |
Change abandoned by Ivan Suzdal <email address hidden> on branch: 10.0/newton
Review: https:/
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change restored on packages/centos7/cobbler (10.0/newton) | #14 |
Change restored by Ivan Suzdal <email address hidden> on branch: 10.0/newton
Review: https:/
Reviewed: https:/
Submitter: Pkgs Jenkins <email address hidden>
Branch: 9.0
Commit: 66a437ca4139431
Author: Ivan Suzdal <email address hidden>
Date: Mon Feb 13 17:53:35 2017
Fix logrotate postrotate command
Change-Id: Ia562039084c237
Closes-Bug: #1656834
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/centos7/cobbler (10.0/newton) | #16 |
Fix proposed to branch: 10.0/newton
Change author: Ivan Suzdal <email address hidden>
Review: https:/
Alexey Stupnikov (astupnikov) wrote : | #17 |
There is a blocking bug #1664635 that locks review process. Ivan will push patches to newton and master as soon as blocker will be fixed.
Alexey Stupnikov (astupnikov) wrote : | #18 |
Newton and master patches that should be merged:
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/centos7/cobbler (master) | #19 |
Reviewed: https:/
Submitter: Pkgs Jenkins <email address hidden>
Branch: master
Commit: 5b50bdc3accde46
Author: Ivan Suzdal <email address hidden>
Date: Mon Feb 27 13:50:30 2017
Fix logrotate postrotate command
Change-Id: I86cfc57953ed97
Closes-Bug: #1656834
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on packages/centos7/cobbler (10.0/newton) | #20 |
Change abandoned by Alexey Stupnikov <email address hidden> on branch: 10.0/newton
Review: https:/
Reason: duplicate
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/centos7/cobbler (10.0/newton) | #21 |
Reviewed: https:/
Submitter: Pkgs Jenkins <email address hidden>
Branch: 10.0/newton
Commit: 48684761ab35c25
Author: Ivan Suzdal <email address hidden>
Date: Mon Feb 27 13:50:49 2017
Fix logrotate postrotate command
Change-Id: I86cfc57953ed97
Closes-Bug: #1656834
tags: | added: on-verification |
TatyanaGladysheva (tgladysheva) wrote : | #22 |
Verified on 9.2 + MU1 updates.
Actual results:
Currently postrotate script is correct in /etc/logrotate.
postrotate
systemctl try-restart cobblerd
endscript
tags: | removed: on-verification |
Ilya Bumarskov (ibumarskov) wrote : | #23 |
Verified on Fuel 10 build #1575:
[root@nailgun ~]# cat /etc/logrotate.
/var/log/
missingok
notifempty
rotate 4
weekly
postrotate
systemctl try-restart cobblerd
endscript
}
...
Alexey, please provide expected and actual result. Why we need to use another approach?