[UI] Invalid value for Custom MTU can be saved

Bug #1652608 reported by Ekaterina Khomyakova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Julia Aranovich
Mitaka
Fix Released
High
Julia Aranovich
Newton
Fix Released
High
Julia Aranovich

Bug Description

Fuel 9.2 #682

Steps to reproduce:
  1. Create env
  2. Add node, select it and press "Configure Interfaces"
  3. Enable custom MTU and set value to -42

Expected results:
  Error message "Value must be greater than or equal to 42" and disabled Apply

Actual result:
  No error message, changes could be saved

Additional information:
  Because of number type it is also possible to set float numbers like 45.53 and numbers with exp like 45e2.

Changed in fuel:
assignee: nobody → Fuel UI Team (fuel-ui)
importance: Undecided → High
status: New → Confirmed
tags: added: area-python
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/415169

Revision history for this message
Julia Aranovich (jkirnosova) wrote :

>> Because of number type it is also possible to set float numbers like 45.53 and numbers with exp like 45e2.

This does not refer to MTU setting and already mentioned in a separate bug.

Changed in fuel:
status: Confirmed → In Progress
assignee: Fuel UI Team (fuel-ui) → Julia Aranovich (jkirnosova)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/415169
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=d96bf4399188cb9aba72b1ee35b4570a06d30698
Submitter: Jenkins
Branch: stable/mitaka

commit d96bf4399188cb9aba72b1ee35b4570a06d30698
Author: Julia Aranovich <email address hidden>
Date: Tue Dec 27 12:38:57 2016 +0300

    Fix migration for NIC's mtu setting

    min and max setting limits added to 9.2 migration

    Closes-Bug: #1652608

    Change-Id: Iae71a611dbc78de49456a717ccf956ae54ad15a9

tags: added: in-stable-mitaka
Changed in fuel:
status: In Progress → Fix Committed
tags: added: on-verification
Revision history for this message
TatyanaGladysheva (tgladysheva) wrote :

Verified on 9.2 snapshot #693.

tags: removed: on-verification
Changed in fuel:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/415627

Changed in fuel:
milestone: 9.2 → 11.0
status: Fix Released → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/415627
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=18f29b354ce1c51ffa0fb4db3185ea1c7aea9320
Submitter: Jenkins
Branch: master

commit 18f29b354ce1c51ffa0fb4db3185ea1c7aea9320
Author: Julia Aranovich <email address hidden>
Date: Tue Dec 27 12:38:57 2016 +0300

    Fix migration for NIC's mtu setting

    min and max setting limits added to 9.2 migration

    Closes-Bug: #1652608

    Change-Id: Iae71a611dbc78de49456a717ccf956ae54ad15a9
    (cherry picked from commit d96bf4399188cb9aba72b1ee35b4570a06d30698)

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/424529

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/newton)

Reviewed: https://review.openstack.org/424529
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=8ac375b40da7b22ab4e94e5c11e44567e6216bed
Submitter: Jenkins
Branch: stable/newton

commit 8ac375b40da7b22ab4e94e5c11e44567e6216bed
Author: Julia Aranovich <email address hidden>
Date: Tue Dec 27 12:38:57 2016 +0300

    Fix migration for NIC's mtu setting

    min and max setting limits added to 9.2 migration

    Closes-Bug: #1652608

    Change-Id: Iae71a611dbc78de49456a717ccf956ae54ad15a9
    (cherry picked from commit d96bf4399188cb9aba72b1ee35b4570a06d30698)
    (cherry picked from commit 18f29b354ce1c51ffa0fb4db3185ea1c7aea9320)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 11.0.0.0rc1

This issue was fixed in the openstack/fuel-web 11.0.0.0rc1 release candidate.

Revision history for this message
Ekaterina Khomyakova (ekhomyakova) wrote :

Verified on Fuel 10 #1413

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.