[Infra] Wrong package version for packages generated for reviews

[Vladimir Sharshov]

Detailed bug description:

Package version generated early numbers compared with actual version which already present in repository.

Steps to reproduce:

1. Create review for fuel-web, for example.
2. Wait until pkg_build_fuel pipeline report about success.
3. Check CentOs repository

Expected results:

Version of package should be higher then version present in repository.

Actual result:

Version of package is lower then version present in repository.

Reproducibility:

Often

Workaround:

No

Impact:

Such behavior block any custom system tests because system installed higher version from main repository instead of custom repository with changes which should be tested.

Description of the environment:
Custom system test: https://custom-ci.infra.mirantis.net/view/9.x/job/9.x.custom.ubuntu.system_test/775/
Review: https://review.openstack.org/#/c/413100/
Generated package for fuel-nailgun: 9.0.0-1.mos8919
Already present package in last succeed snapshot: 9.0.0-1.mos8924
Repo url for review: http://packages.fuel-infra.org/review/FUEL-413100/repositories/centos/mitaka-centos7/snapshots/os-2016-12-21-112701/x86_64/Packages/
Repo url for last succeed snapshot: http://mirror.seed-cz1.fuel-infra.org/mos-repos/centos/mos9.0-centos7/snapshots/proposed-2016-12-20-174323/x86_64/Packages

[Roman Vyalov (r0mikiam)]

you are using the public packaging ci in mos . I mean are you trying to use the packages from public ci ( http://packages.fuel-infra.org/review/FUEL-413100/repositories/centos/mitaka-centos7/snapshots/os-2016-12-21-112701/x86_64/Packages/ ) in the mos system test http://mirror.seed-cz1.fuel-infra.org/mos-repos/centos/mos9.0-centos7/snapshots/proposed-2016-12-20-174323/x86_64/Packages

Because of this , i decrease the priority to medium. we will try to investigate how we can build packages in public with the same as in mos

[Vladimir Sharshov (vsharshov)]

Guys, i talk today with Ivan Remizov and he told me about differents between upstream and downstream.

Now i understand the reason why it happened, but i still do not see solution for such behavior.

After discussion with Ivan Remizov, Dmitry Pyzhov and me we think about several reasons:

- add additional tag for mos/downstream to decrease version;
- add special job in Jenkins which can build repositories with packages based on downstream repositories where developers should give reviews id aka refs/changes/49/382349/12 for needed packages. It will build repositories which can be used for custom system tests.
- add special bot for reviews which will build packages for downstream for every review as for upstream.

I do not want to cause war for bug importance. I really think that bug is critical because it lock any custom system tests and block developers works.

[Alexander Evseev (aevseev)]

To fix this behavior it is needed either to add priorities to fuel-qa's UPDATE_FUEL_MIRROR or raise version of packages intended for testing (not for publishing!).

I can't decide about the complexity of the first option...

Second option can be implemented by adding one more Perestroika parameter to override package epoch (only for GERRIT_CHANGE_STATUS=NEW). Then we can set some big epoch value for all packages built by public packaging CI, and those packages will always beat MOS packages.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/418385

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/418388

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/418391

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/418385
Committed: https://git.openstack.org/cgit/openstack/fuel-mirror/commit/?id=84307dbfb5706c007b04c94c4c2950f991db2c23
Submitter: Jenkins
Branch: master

commit 84307dbfb5706c007b04c94c4c2950f991db2c23
Author: Dmitry Burmistrov <email address hidden>
Date: Tue Jan 10 17:31:54 2017 +0400

    [build] Customise fuel pkg revision

       Allow to change fuel package revision from CI side

       Related-Bug: #1651771

    Change-Id: I10e158256e8c0f7cd32f74ba05bfdb1cf376a83a

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/418388
Committed: https://git.openstack.org/cgit/openstack/fuel-mirror/commit/?id=4782ae3161d2e554614f180bd1ac335abd2ceaeb
Submitter: Jenkins
Branch: stable/mitaka

commit 4782ae3161d2e554614f180bd1ac335abd2ceaeb
Author: Dmitry Burmistrov <email address hidden>
Date: Tue Jan 10 17:31:54 2017 +0400

    [build] Customise fuel pkg revision

       Allow to change fuel package revision from CI side

       Related-Bug: #1651771

    Change-Id: I10e158256e8c0f7cd32f74ba05bfdb1cf376a83a

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/418391
Committed: https://git.openstack.org/cgit/openstack/fuel-mirror/commit/?id=7915c0ae25f01aa62d93644a4bdb7eb8c9027df9
Submitter: Jenkins
Branch: stable/newton

commit 7915c0ae25f01aa62d93644a4bdb7eb8c9027df9
Author: Dmitry Burmistrov <email address hidden>
Date: Tue Jan 10 17:31:54 2017 +0400

    [build] Customise fuel pkg revision

       Allow to change fuel package revision from CI side

       Related-Bug: #1651771

    Change-Id: I10e158256e8c0f7cd32f74ba05bfdb1cf376a83a

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: master
Change author: Alexander Evseev <email address hidden>
Review: https://review.fuel-infra.org/29752

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/29752
Submitter: Alexander Evseev <email address hidden>
Branch: master

Commit: 13085e8458ccb54897ea462a7fc729807173e1e6
Author: Alexander Evseev <email address hidden>
Date: Wed Jan 11 07:43:54 2017

[pkgs-ci-pub] Override Fuel package revisions

To be able to test upstream Fuel packages having lesser revision that
downstream ones, it's need to raise version/revision.

Also disable unneded anymore IS_DOWNGRADE.

Change-Id: Ib203870edbd5b7348f05ba83d0529960e13abcf4
Related-Bug: #1651771

[Alexander Evseev (aevseev)]

We created a solution increasing package revision for Fuel packages built by public packaging CI during test phase.

Now you can try to use newly created by public builder/publisher repositories in custom tests.

Here is example repositories: http://packages.fuel-infra.org/review/FUEL-414470/repositories/

Note package revision - it has '2' as first digit while downstream packages have '1'.