User cannot deploy changes, because button has disappeared on UI

[Nastya Urlapova]

This issues was found while exploratory testing. After unsuccessful deploy https://bugs.launchpad.net/fuel/+bug/1650652, I've added systemd-shim package into list of extra packages, see pic 1., further I've saved the settings. But on the main tab, "Deployment changes" button didn't appeared, see pic 2.

Conclusion what UI-team has provided:
user doesn't see "Deploy changes" button, because initial hash for deployment wasn't saved GET /api/clusters/1/attributes/deployed. And new setting have nothing to compare.

A brief scenario:
1. get an error on deployment
2. change smth. in general settings
3. try to deploy changes

Version:
9.x snapshot #638

[Vladimir Kuklin (vkuklin)]

I failed to reproduce the issue with an existing environment. Will try to do it with brand new one.

[Stanislaw Bogatkin (sbogatkin)]

I have seen this exact bug when tested other stuff yesterday. Problem also disappeared after cluster reset and successful deploy.

[Vladimir Kuklin (vkuklin)]

I failed to reproduce this scenario with brand new environment either:

1. Have sample 3controller+1compute env
2. Put some gibberish to fuel_pkgs.pp manifest
3. Run the deployment
4. Deployment fails
5. Change repositories settings and something else.
6. Deploy Changes button is still in place.

[Vladimir Kuklin (vkuklin)]

Okay, I finally got it. If /api/clusters/{cluster_id}/attributes/deployed returns an empty hash (which is ok, because there has not been a single successful deployment yet), then Deployed Changes button is not shown. I am pretty sure that if have empty deployed hash, then this would mean that we have not deployed anything yet and 'Deploy Changes' button should be shown. Thus I will reassign this bug to fuel-ui team

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/413466

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/413466
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=a4eebede2d3840c2665468b8c0d791bf63443233
Submitter: Jenkins
Branch: master

commit a4eebede2d3840c2665468b8c0d791bf63443233
Author: Julia Aranovich <email address hidden>
Date: Wed Dec 21 10:41:37 2016 +0300

    Allow to redeploy error nodes

    If there are error nodes in cluster,
    Deploy Changes button should be available on Dashboard
    for user to be able to redeploy the nodes.

    Closes-Bug: #1650663

    Change-Id: Ife0c0034fd181caf84ec22ac738118f0fbaae81d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/413518

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/413520

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/413518
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=2dc13ee6641d831f45d2d35d0978378f27321442
Submitter: Jenkins
Branch: stable/newton

commit 2dc13ee6641d831f45d2d35d0978378f27321442
Author: Julia Aranovich <email address hidden>
Date: Wed Dec 21 10:41:37 2016 +0300

    Allow to redeploy error nodes

    If there are error nodes in cluster,
    Deploy Changes button should be available on Dashboard
    for user to be able to redeploy the nodes.

    Closes-Bug: #1650663

    Change-Id: Ife0c0034fd181caf84ec22ac738118f0fbaae81d
    (cherry picked from commit a4eebede2d3840c2665468b8c0d791bf63443233)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/413520
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=1dde97671f65d70dd3c9f3e7cb3f566ea21271df
Submitter: Jenkins
Branch: stable/mitaka

commit 1dde97671f65d70dd3c9f3e7cb3f566ea21271df
Author: Julia Aranovich <email address hidden>
Date: Wed Dec 21 10:41:37 2016 +0300

    Allow to redeploy error nodes

    If there are error nodes in cluster,
    Deploy Changes button should be available on Dashboard
    for user to be able to redeploy the nodes.

    Closes-Bug: #1650663

    Change-Id: Ife0c0034fd181caf84ec22ac738118f0fbaae81d
    (cherry picked from commit a4eebede2d3840c2665468b8c0d791bf63443233)

[Ekaterina Shutova (eshutova)]

Verified on 9.2 snapshot #666

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-ui 11.0.0.0rc1 release candidate.