Fuel plugin builder generates spec which creates a symlink, which breaks backward compatibility

Bug #1648882 reported by Evgeniy L on 2016-12-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
High
Evgeniy L

Bug Description

Detailed bug description:
 Fix https://github.com/openstack/fuel-plugins/commit/3f33bf09e3df3a66a01d6a7bb4d324a62975c700
 https://bugs.launchpad.net/fuel/+bug/1603987
 leads to rpm installation errors, if it was previously workarounded manually.

Transaction check error:
  file /var/www/nailgun/plugins/connectivity_checker-9.1 conflicts between attempted installs of connectivity_checker-9.1-9.1.2-1.noarch and connectivity_checker-9.1-9.1.2-1.noarch

Moreover the fix is broken, because `deployment_scripts` must not be hardcoded in the spec, because it is not static, but dynamic parameter which is configured in metadata.yaml

Workaround:
 Use older version of fuel-plugin-builder
Impact:
 Impacts all users whose plugins are built with newest fpb and those users who used workaround by creating symlink manually. And all plugins where deployment_scripts is configured to different one.

Description of the environment:
 fpb 4.1.0

Evgeniy L (rustyrobot) on 2016-12-09
tags: added: area-plugins
removed: module-nailgun

Reviewed: https://review.openstack.org/409377
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=0bb6ffbcb5ee6734fcf5dfd5f4dca20a5caa3b88
Submitter: Jenkins
Branch: master

commit 0bb6ffbcb5ee6734fcf5dfd5f4dca20a5caa3b88
Author: Evgeny L <email address hidden>
Date: Sat Dec 10 00:04:53 2016 +0000

    Create symlink which is required for master node plugin tasks

    Place where plugins are linked depends on configuration (of Nailgun,
    MCollective, Astute), hence must not be hardcoded in specs and
    should be done by puppet manifests which own master node configuration
    details.

    Change-Id: I1e9db92f9fc8dc70403113d1d6f9062b689dd2ee
    Related-bug: #1603987
    Closes-bug: #1648882

Changed in fuel:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/411904
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=c48b67f10d44beb07595fa90ea7fad3ad9da2209
Submitter: Jenkins
Branch: stable/mitaka

commit c48b67f10d44beb07595fa90ea7fad3ad9da2209
Author: Evgeny L <email address hidden>
Date: Sat Dec 10 00:04:53 2016 +0000

    Create symlink which is required for master node plugin tasks

    Place where plugins are linked depends on configuration (of Nailgun,
    MCollective, Astute), hence must not be hardcoded in specs and
    should be done by puppet manifests which own master node configuration
    details.

    Change-Id: I1e9db92f9fc8dc70403113d1d6f9062b689dd2ee
    Related-bug: #1603987
    Closes-bug: #1648882
    (cherry picked from commit 0bb6ffbcb5ee6734fcf5dfd5f4dca20a5caa3b88)

tags: added: in-stable-mitaka
tags: added: in-stable-newton

Reviewed: https://review.openstack.org/411903
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=7811459e976aa8df06754316249d9509f7b79bc6
Submitter: Jenkins
Branch: stable/newton

commit 7811459e976aa8df06754316249d9509f7b79bc6
Author: Evgeny L <email address hidden>
Date: Sat Dec 10 00:04:53 2016 +0000

    Create symlink which is required for master node plugin tasks

    Place where plugins are linked depends on configuration (of Nailgun,
    MCollective, Astute), hence must not be hardcoded in specs and
    should be done by puppet manifests which own master node configuration
    details.

    Change-Id: I1e9db92f9fc8dc70403113d1d6f9062b689dd2ee
    Related-bug: #1603987
    Closes-bug: #1648882
    (cherry picked from commit 0bb6ffbcb5ee6734fcf5dfd5f4dca20a5caa3b88)

Reviewed: https://review.openstack.org/409322
Committed: https://git.openstack.org/cgit/openstack/fuel-plugins/commit/?id=13c73e560959f2de7acc7227a616fb90edd54d05
Submitter: Jenkins
Branch: master

commit 13c73e560959f2de7acc7227a616fb90edd54d05
Author: Evgeny L <email address hidden>
Date: Fri Dec 9 20:19:41 2016 +0000

    Revert "Make a symlink to deployment scripts in /etc"

    The fix broke backward compatibility and used hardcoded
    value.

    Related-bug: #1603987
    Related-bug: #1648882
    This reverts commit 3f33bf09e3df3a66a01d6a7bb4d324a62975c700.

    Change-Id: Ie3420116926bef518d68c3e3b381e5cff4c98b6f

This issue was fixed in the openstack/fuel-library 11.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers