[Plugins] Wrong tasks priority in case of deploy additional nodes

[Vladimir Sharshov]

Detailed bug description:

  Fuel failed with wrong tasks order in fuel 8.0 with installed
  plugin fuel-plugin-lma-collector when try to add new node in already
  installed plugin

  Core reason: Nailgun process tasks with wrong priority. Task lma-base
  should run before lma-main-controller https://github.com/openstack/fuel-plugin-lma-collector/blob/0.10.1/deployment_tasks.yaml#L32-L66

  It works in case of main deploy, but failed second time.

Steps to reproduce:
  1. Create new cluster with activated LMA plugin
  2. Deploy cluster with controllers and computes
  3. Add new compute and run deploy

Expected results:

  Deploy succeed. LMA works

Actual result:

  Deploy succeed. LMA was not worked on new compute nodes

Reproducibility:

  Always

Workaround:

  No

Impact:

  Such error is a sign of problem with tasks manager in 8.0. In 9.0 or higher we use new task deployment action which is why this bug assigned only for 8.0.

Description of the environment:

 Versions of components: Fuel 8.0
 Related projects installed: LMA plugin

Additional information:

   Example of wrong priority. Task with less priority field run early.

parameters:
  puppet_modules: puppet/modules:/etc/puppet/modules
  puppet_manifest: puppet/manifests/base.pp
  timeout: 600
  cwd: /etc/fuel/plugins/lma_collector-0.10/
priority: 1600
fail_on_error: true
type: puppet
id: lma-base

parameters:
  puppet_modules: puppet/modules:/etc/puppet/modules
  puppet_manifest: puppet/manifests/controller.pp
  timeout: 600
  cwd: /etc/fuel/plugins/lma_collector-0.10/
priority: 1100
fail_on_error: true
type: puppet
id: lma-main-controller

[Alexander Kislitsky (akislitsky)]

I had tried to reproduce this bug with nailgun integration tests and on the test env. Bug wasn't reproduced. I can't find the root cause without access to the env with reproduced bug.

May be there are some customisations in the deployment tasks files on the problem env.
Could you please provide all *tasks.yaml from all installed plugins.
Run on master-node the following:

  cd /var/www/plugins
  find . -name '*tasks.yaml' | xargs tar -czvf tasks_files.tar.gz

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/408535

[Alexander Kislitsky (akislitsky)]

Fix was provided. Waiting for merge from the Maintenance team.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Andreas Jaeger (<email address hidden>) on branch: stable/8.0
Review: https://review.opendev.org/408535
Reason: This repo is retired now, no further work will get merged.