Fuel for OpenStack

SR-IOV numvfs setting is invalid by default

Bug #1643600 reported by Julia Aranovich
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Fedor Zhadaev
Fuel for OpenStack 11.0
Mitaka
Fix Released
High
Fedor Zhadaev
Fuel for OpenStack 9.2
Newton
Fix Released
High
Alexey Shtokolov
Fuel for OpenStack 10.1

Bug Description

Steps to reproduce:

1. create an environment (any settings)
2. add a node to the environment with SR-IOV enabled inteface(s) and go to the node interfaces configuration screen
3. enable SR-IOV on a node interface and check SR-IOV settings

Expected result: all SR-IOV settings are valid by default
Actual result: numvfs setting is marked as invalid on UI.

UI highlights numvfs field because it has "number" type and "null" default value. "null" isn't recognized by UI as valid number input value.

Proposed solution is to add nullable=true flag to numvfs setting
(which was supported on UI https://review.openstack.org/412118).
It will generate checkbox near the number control, that indicates
if setting value is null or not.

See original description
Oleksiy Molchanov (omolchanov)
Changed in fuel:
assignee: nobody → Fuel Sustaining (fuel-sustaining-team)
Andriy Popovych (popovych-andrey)
Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Andriy Popovych (popovych-andrey)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/412118

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/412119

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (stable/mitaka)

Reviewed: https://review.openstack.org/412118
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=cd8d1d5445f9e13e56c8b2ac537fd0f879553e8c
Submitter: Jenkins
Branch: stable/mitaka

commit cd8d1d5445f9e13e56c8b2ac537fd0f879553e8c
Author: Julia Aranovich <email address hidden>
Date: Mon Dec 19 12:21:33 2016 +0300

    Support "nullable" setting attribute

    Partial-Bug: #1643599
    Partial-Bug: #1643600

    Change-Id: I036ecad2c60c8208d926b8a6c9a4a13c1f43a8fe

tags: added: in-stable-mitaka
Julia Aranovich (jkirnosova)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/414575

Changed in fuel:
assignee: Andriy Popovych (popovych-andrey) → Julia Aranovich (jkirnosova)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (master)

Reviewed: https://review.openstack.org/414575
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=96a41f83454f9d554f19e73902958079ea5b38a7
Submitter: Jenkins
Branch: master

commit 96a41f83454f9d554f19e73902958079ea5b38a7
Author: Julia Aranovich <email address hidden>
Date: Mon Dec 19 12:21:33 2016 +0300

    Support "nullable" setting attribute

    Partial-Bug: #1643599
    Partial-Bug: #1643600

    Change-Id: I036ecad2c60c8208d926b8a6c9a4a13c1f43a8fe

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/414842

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (stable/newton)

Reviewed: https://review.openstack.org/414842
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=c0e055b973e4f90174b8fb533d0d646452ae6a28
Submitter: Jenkins
Branch: stable/newton

commit c0e055b973e4f90174b8fb533d0d646452ae6a28
Author: Julia Aranovich <email address hidden>
Date: Mon Dec 19 12:21:33 2016 +0300

    Support "nullable" setting attribute

    Partial-Bug: #1643599
    Partial-Bug: #1643600

    Change-Id: I036ecad2c60c8208d926b8a6c9a4a13c1f43a8fe

tags: added: in-stable-newton
Julia Aranovich (jkirnosova)
Changed in fuel:
assignee: Julia Aranovich (jkirnosova) → Fuel Sustaining (fuel-sustaining-team)
status: In Progress → Confirmed
Revision history for this message
Julia Aranovich (jkirnosova) wrote :

UI patch was merged. nullable flag should be added to sriov.numvfs setting in Nailgun

Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Fedor Zhadaev (fzhadaev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/415430

Changed in fuel:
status: Confirmed → In Progress
Fedor Zhadaev (fzhadaev)
Changed in fuel:
milestone: 9.2 → 11.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/415430
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=66e85fec7f97c599237544bc3beb9e4e17adf964
Submitter: Jenkins
Branch: master

commit 66e85fec7f97c599237544bc3beb9e4e17adf964
Author: Fedor Zhadaev <email address hidden>
Date: Wed Dec 28 14:14:52 2016 +0400

    Make SR-IOV numvfs setting nullable

    Change-Id: I134d4002d6ce825c6986b930a515012bcdf4b551
    Closes-bug: #1643600

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/418897

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/418917

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/newton)

Reviewed: https://review.openstack.org/418897
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=6b9b4ae71552d003586bf94a1ea2e6bb02f8b32c
Submitter: Jenkins
Branch: stable/newton

commit 6b9b4ae71552d003586bf94a1ea2e6bb02f8b32c
Author: Fedor Zhadaev <email address hidden>
Date: Wed Dec 28 14:14:52 2016 +0400

    Make SR-IOV numvfs setting nullable

    Change-Id: I134d4002d6ce825c6986b930a515012bcdf4b551
    Closes-bug: #1643600
    (cherry picked from commit 66e85fec7f97c599237544bc3beb9e4e17adf964)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/418917
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=b44fff15a02c979e6ede4e4ea07df599d35fef4d
Submitter: Jenkins
Branch: stable/mitaka

commit b44fff15a02c979e6ede4e4ea07df599d35fef4d
Author: Fedor Zhadaev <email address hidden>
Date: Wed Dec 28 14:14:52 2016 +0400

    Make SR-IOV numvfs setting nullable

    Change-Id: I134d4002d6ce825c6986b930a515012bcdf4b551
    Closes-bug: #1643600
    (cherry picked from commit 66e85fe)

Dmitry Belyaninov (dbelyaninov)
tags: added: on-verification
Dmitry Belyaninov (dbelyaninov)
tags: removed: on-verification
TatyanaGladysheva (tgladysheva)
tags: added: on-verification
TatyanaGladysheva (tgladysheva)
tags: removed: on-verification
Revision history for this message
Kristina Berezovskaia (kkuznetsova) wrote :

Verify on 9.2 snap #801

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 11.0.0.0rc1

This issue was fixed in the openstack/fuel-web 11.0.0.0rc1 release candidate.

Revision history for this message
Vladimir Khlyunev (vkhlyunev) wrote :

Verified on baremetal lab on 1575 build

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.