MTU is invalid by default

[Julia Aranovich]

Steps to reproduce:

1. create an environment (any settings)
2. add a node to the environment and go to the node interfaces configuration screen
3. check the node NICS' settings

Expected result: all NICS' settings are valid by default

Actual result: MTU setting is marked as invalid on UI for each NIC.

UI highlights MTU field because it has "number" type and "null" value. "null" isn't recognized by UI as valid number input value.
Proposed solution is to change MTU settings in the following way:

mtu: {
  metadata: {...},
  use_custom_mtu: {
    type: 'checkbox'
    value: false,
    label: 'Use custom MTU value',
    description: ?,
    weight: 10
  },
  custom_mtu: {
    type: 'number',
    value: 42,
    min: 42,
    max: ?,
    weight: 20,
    label: 'Custom MTU value',
    description: ?,
    restrictions: ['nic_attributes:mtu.use_custom_mtu.value = false']
  }
}

This will guarantee having not a null value for number input and will make MTU settings UX more clear.

[Yury Tregubov (ytregubov)]

Seems that this bug affects change of setting for NFV. It is impossible to enable sr-iov and dpdk on interafce nither via FUEL UI or API:

Update attributes of nodes ... 2016-11-30 12:19:51 - INFO factory.py:36 --
<<< ------------------------------------------------[ START Step 009. Update attributes of nodes ]------------------------------------------------ >>>

2016-11-30 12:19:51 - INFO fuel_web_client.py:1148 -- Get nailgun node by slave-02 devops node
2016-11-30 12:19:51 - INFO test_deploy_env.py:130 -- Set `cpu_pinning/nova/value` to `18`
2016-11-30 12:19:51 - INFO fuel_web_client.py:1148 -- Get nailgun node by slave-03 devops node
2016-11-30 12:19:52 - INFO test_deploy_env.py:130 -- Set `hugepages/nova/value/2048` to `16000`
2016-11-30 12:19:52 - INFO test_deploy_env.py:130 -- Set `hugepages/nova/value/1048576` to `10`
2016-11-30 12:19:52 - INFO fuel_web_client.py:1148 -- Get nailgun node by slave-04 devops node
FAIL
Run network checker ... SKIP: Failure in <function Case_DeployEnv__Config_sr-iov_ceph.Step009_update_nodes at 0x7fadbb2d8488>
Deploy environment ... SKIP: Failure in <function Case_DeployEnv__Config_sr-iov_ceph.Step009_update_nodes at 0x7fadbb2d8488>
Run network checker ... SKIP: Failure in <function Case_DeployEnv__Config_sr-iov_ceph.Step009_update_nodes at 0x7fadbb2d8488>
Run health checker ... SKIP: Failure in <function Case_DeployEnv__Config_sr-iov_ceph.Step009_update_nodes at 0x7fadbb2d8488>
Finish test case ... 2016-11-30 12:19:53 - INFO base.py:116 --
<<< ========================================[ FINISH Deploy cluster for tests CASE TOOK 49.0 min 33 sec ]========================================= >>>

ok

======================================================================
FAIL: Update attributes of nodes
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins/workspace/9.x_SR-IOV_Ceph_baremetal/mos-ci-deployment-scripts/fuel-devops-venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/home/jenkins/workspace/9.x_SR-IOV_Ceph_baremetal/mos-ci-deployment-scripts/fuel-devops-venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/home/jenkins/workspace/9.x_SR-IOV_Ceph_baremetal/mos-ci-deployment-scripts/fuel-devops-venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/9.x_SR-IOV_Ceph_baremetal/mos-ci-deployment-scripts/fuel-qa/system_test/core/factory.py", line 37, in wrapper
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/9.x_SR-IOV_Ceph_baremetal/mos-ci-deployment-scripts/fuel-qa/system_test/tests/test_deploy_env.py", line 235, in update_nodes
    replacements_list=interfaces_list)
  File "/home/jenkins/workspace/9.x_SR-IOV_Ceph_baremetal/mos-ci-deployment-scripts/fuel-qa/system_test/tests/test_deploy_env.py", line 205, in _update_node_interfaces
    dict_values=interface_dict)
  File "/home/jenkins/workspace/9.x_SR-IOV_Ceph_baremetal/mos-ci-deployment-...

[Yury Tregubov (ytregubov)]

On 9.2 snapshot 574 checked the following.

In FUEL UI in interface configuration menu if MTU value is set to 1500 for all interfaces on the node, than it is possible to save changes for sr-iov and dpdk.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/408721

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/411300
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=ce5634fba48d9e672707381cceea50a1f76b19ae
Submitter: Jenkins
Branch: stable/mitaka

commit ce5634fba48d9e672707381cceea50a1f76b19ae
Author: Andriy Popovych <email address hidden>
Date: Thu Dec 15 15:04:10 2016 +0200

    Skip MTU tests

    Related-Bug: #1643599
    Change-Id: I9404737f16ebd2245241a09dfbd1bb9d98b34bd2

[Julia Aranovich (jkirnosova)]

Current bug status:
2 patches needed to close this bug:

[1] https://review.openstack.org/411300 (fuel-ui) - MERGED - skip the check of NIC's attributes in Fuel UI autotests, to unblock merge of main Nailgun patch (for Fuel CI to be green)

[2] https://review.openstack.org/#/c/408721/ (fuel-web) - ON REVIEW - Nailgun fix for the bug

Additional notes:
* no changes required in fuel-library
* test commented in [1] should be restored after merging of [2]

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/411674

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/411677

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/411674
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=a76aa6b0aeacdc12748591df6a20e15d67275963
Submitter: Jenkins
Branch: stable/mitaka

commit a76aa6b0aeacdc12748591df6a20e15d67275963
Author: Julia Aranovich <email address hidden>
Date: Fri Dec 16 10:36:08 2016 +0300

    Pass interface model to validation

    Related-Bug: #1643599

    Change-Id: Iafda0ed9a00054e14072876b407f2ad80847ecb6

[Julia Aranovich (jkirnosova)]

Current bug status (16-12-2016):

Fix is ready https://review.openstack.org/#/c/408721/ but reviewers do not approve the proposed solution.
We've started to work on a better solution. New ETA will be provided on Monday, 19-12-2016.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/412118

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/412119

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/411677
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=5759b8376c039694e28d91be12e874c2ab5dfdfb
Submitter: Jenkins
Branch: master

commit 5759b8376c039694e28d91be12e874c2ab5dfdfb
Author: Julia Aranovich <email address hidden>
Date: Fri Dec 16 10:36:08 2016 +0300

    Pass interface model to validation

    Related-Bug: #1643599

    Change-Id: Iafda0ed9a00054e14072876b407f2ad80847ecb6

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/408721
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=69a3f60a84fc6a5c6c332f7aad5d50b65856e243
Submitter: Jenkins
Branch: stable/mitaka

commit 69a3f60a84fc6a5c6c332f7aad5d50b65856e243
Author: Andriy Popovych <email address hidden>
Date: Wed Dec 7 12:18:54 2016 +0200

    Add custom MTU attribute

    Interface MTU control is modified (split to 'use_custom_mtu' and 'cuxtom_mtu') settings
    to render a valid settings form on UI and unlock Fuel 9.2 testing.

    This is a temporary solution and should be reverted after merge
    of proper #1643599 fix.

    Change-Id: I28ea516cfb13bd4d55e324b5299f5e71e3a858af
    Related-Bug: #1643599

[Julia Aranovich (jkirnosova)]

Current status (19/12/2016):

* the temporary fix was merged to stable/mitaka branch (https://review.openstack.org/408721)
* a proper fix is in progress. Plan is to land it during this week.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/412118
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=cd8d1d5445f9e13e56c8b2ac537fd0f879553e8c
Submitter: Jenkins
Branch: stable/mitaka

commit cd8d1d5445f9e13e56c8b2ac537fd0f879553e8c
Author: Julia Aranovich <email address hidden>
Date: Mon Dec 19 12:21:33 2016 +0300

    Support "nullable" setting attribute

    Partial-Bug: #1643599
    Partial-Bug: #1643600

    Change-Id: I036ecad2c60c8208d926b8a6c9a4a13c1f43a8fe

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/412119
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=12e0f7ed12f0ef39a02cf09143ed2d55883b340d
Submitter: Jenkins
Branch: stable/mitaka

commit 12e0f7ed12f0ef39a02cf09143ed2d55883b340d
Author: Julia Aranovich <email address hidden>
Date: Tue Dec 20 13:35:40 2016 +0300

    Add nullable flag to NIC's mtu attribute

    Partial-Bug: #1643599

    Change-Id: I8cd2b972c4be053ebbcb0cc788c1ee0384120374

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/414575

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/414575
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=96a41f83454f9d554f19e73902958079ea5b38a7
Submitter: Jenkins
Branch: master

commit 96a41f83454f9d554f19e73902958079ea5b38a7
Author: Julia Aranovich <email address hidden>
Date: Mon Dec 19 12:21:33 2016 +0300

    Support "nullable" setting attribute

    Partial-Bug: #1643599
    Partial-Bug: #1643600

    Change-Id: I036ecad2c60c8208d926b8a6c9a4a13c1f43a8fe

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/414842

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/414844

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/414842
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=c0e055b973e4f90174b8fb533d0d646452ae6a28
Submitter: Jenkins
Branch: stable/newton

commit c0e055b973e4f90174b8fb533d0d646452ae6a28
Author: Julia Aranovich <email address hidden>
Date: Mon Dec 19 12:21:33 2016 +0300

    Support "nullable" setting attribute

    Partial-Bug: #1643599
    Partial-Bug: #1643600

    Change-Id: I036ecad2c60c8208d926b8a6c9a4a13c1f43a8fe

[Ekaterina Shutova (eshutova)]

Verified on 9.2 snapshot #682

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/414844
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=b82e6e5affaf8eaaa0e1944658229beb973028fb
Submitter: Jenkins
Branch: master

commit b82e6e5affaf8eaaa0e1944658229beb973028fb
Author: Julia Aranovich <email address hidden>
Date: Tue Dec 20 13:35:40 2016 +0300

    Add nullable flag to NIC's mtu attribute

    Partial-Bug: #1643599

    Change-Id: I8cd2b972c4be053ebbcb0cc788c1ee0384120374

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/415842

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/415842
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=382cddaf002199e6101d571fbaa5f8d45eb14038
Submitter: Jenkins
Branch: stable/newton

commit 382cddaf002199e6101d571fbaa5f8d45eb14038
Author: Julia Aranovich <email address hidden>
Date: Fri Dec 16 10:36:08 2016 +0300

    Pass interface model to validation

    Related-Bug: #1643599

    Change-Id: Iafda0ed9a00054e14072876b407f2ad80847ecb6
    (cherry picked from commit 5759b8376c039694e28d91be12e874c2ab5dfdfb)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/421720

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/421720
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=5fd05b30e871bf45087764a2416745952de86cb0
Submitter: Jenkins
Branch: stable/newton

commit 5fd05b30e871bf45087764a2416745952de86cb0
Author: Julia Aranovich <email address hidden>
Date: Tue Dec 20 13:35:40 2016 +0300

    Add nullable flag to NIC's mtu attribute

    Partial-Bug: #1643599

    Change-Id: I8cd2b972c4be053ebbcb0cc788c1ee0384120374
    (cherry picked from commit b82e6e5affaf8eaaa0e1944658229beb973028fb)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/429584

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/429585

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/429589

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/429584
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=8b38eb94afb31f3f7459583d2508583982afb5de
Submitter: Jenkins
Branch: master

commit 8b38eb94afb31f3f7459583d2508583982afb5de
Author: Julia Aranovich <email address hidden>
Date: Mon Feb 6 12:19:34 2017 +0300

    Restore MTU tests

    Restore UI functional tests which check interface MTU setting.
    These tests were commented out to unblock MTU setting refactoring.

    Related-Bug: #1643599

    Change-Id: I8949feee9028527f6f13e9cf6daeb9076ae09099

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/429585
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=6be1a5d3a0b534021b6d5e0120cab48dfbfc0113
Submitter: Jenkins
Branch: stable/newton

commit 6be1a5d3a0b534021b6d5e0120cab48dfbfc0113
Author: Julia Aranovich <email address hidden>
Date: Mon Feb 6 12:19:34 2017 +0300

    Restore MTU tests

    Restore UI functional tests which check interface MTU setting.
    These tests were commented out to unblock MTU setting refactoring.

    Related-Bug: #1643599

    Change-Id: I8949feee9028527f6f13e9cf6daeb9076ae09099

[OpenStack Infra (hudson-openstack)]

Change abandoned by Julia Aranovich (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/429589

[Ekaterina Shutova (eshutova)]

Verified on 10.1 #1578.
MTU is valid by default.