Deployment tasks can't be triggered leading to failure of virtual Controllers spawning

[Alexander Rubtsov]

MOS: 9.0/stable at October 31

Deployment tasks couldn’t be triggered leading to failure of vCIC spawning.
This is because of the change introduced as part of the blueprint https://blueprints.launchpad.net/fuel/+spec/graph-concept-extension which was targeting MOS10.0.
However, the code parts are already in master as well as in stable/mitaka.

The problem seems to be a coding bug in deployment_serializers.py:
def inject_provision_info(self, common_attrs, node, data):
  if node.replaced_provisioning_info:
    info = node.replaced_provision_info
  else:
    info = self._provision_serializer.serialize_node(
      common_attrs, node
    )
  utils.dict_update(data.setdefault('provision', {}), info)

There is no such entry as "replaced_provision_info" in the database
There is "replaced_provisioning_info" instead.

[Alexander Rubtsov (arubtsov)]

sla1 for 9.0-updates

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/401235

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/401236

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/401237

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/401237
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=c92e6aa99ead942ab22a0297e1fba93968994418
Submitter: Jenkins
Branch: stable/mitaka

commit c92e6aa99ead942ab22a0297e1fba93968994418
Author: Sergey Abramov <email address hidden>
Date: Wed Nov 23 15:17:02 2016 +0300

    Bugfix attr rename

    rename node attr from replaced_provision_info to
    replaced_provisioning_info

    Change-Id: I3e714fc6f6454eeb46797f3be10b1c20385a5e18
    Closes-bug: 1643143

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/401235
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=4c3d4bdace57c80ae1b296e1ea2b27eecde0ee0a
Submitter: Jenkins
Branch: master

commit 4c3d4bdace57c80ae1b296e1ea2b27eecde0ee0a
Author: Sergey Abramov <email address hidden>
Date: Wed Nov 23 15:17:02 2016 +0300

    Bugfix attr rename

    rename node attr from replaced_provision_info to
    replaced_provisioning_info

    Change-Id: I3e714fc6f6454eeb46797f3be10b1c20385a5e18
    Closes-bug: 1643143

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/401236
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=6c3e39eab3f9339017149ebcc4963b37def01cfd
Submitter: Jenkins
Branch: stable/newton

commit 6c3e39eab3f9339017149ebcc4963b37def01cfd
Author: Sergey Abramov <email address hidden>
Date: Wed Nov 23 15:17:02 2016 +0300

    Bugfix attr rename

    rename node attr from replaced_provision_info to
    replaced_provisioning_info

    Change-Id: I3e714fc6f6454eeb46797f3be10b1c20385a5e18
    Closes-bug: 1643143

[TatyanaGladysheva (tgladysheva)]

Verification of this bug is blocked by https://bugs.launchpad.net/fuel/+bug/1648786.

[TatyanaGladysheva (tgladysheva)]

Waiting for customer will verify the fix.

[TatyanaGladysheva (tgladysheva)]

Addition for comment 9: This bug was found by customer using their own deployment scripts and don't have clear steps to reproduce, so we desided to ask customer to check the fix. Testing of this fix is approved by customer's PM at 10-Jan-2017 and customer should start testing at 16-Jan-2017 or later (arubtsov communicated with customer).

[Nastya Urlapova (aurlapova)]

@Andrey, please don't forget to update the issue status after customer's responce. According to our rules issue was moved to "Fix Released", but we cannot verify the fix!

[Alexander Rubtsov (arubtsov)]

@Nastya,

Unfortunately, the customer has not been responding regarding the verification results and the corresponding support case has been closed due to timeout. So, the status of the fix remained unknown for us as well.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 11.0.0.0rc1 release candidate.

[Sergey Novikov (snovikov)]

According to comments #10-12 I've moved the bug to "Incomplete" state for 10.0