Systemd configs in docker containers contain errors and deprecated options

[Rodion Tikunov]

Systemd configs in docker containers contain errors and deprecated options. It would be good to fix them.

Steps to reproduce:
docker logs fuel-core-8.0-rabbitmq
[/etc/systemd/system/start-container.service:4] Unknown lvalue 'ConditionFileExecutable' in section 'Unit'
[/etc/systemd/system/rabbitmq-server.service:10] Executable path is not absolute, ignoring: chown -R rabbitmq:rabbitmq /var/lib/rabbitmq

docker logs fuel-core-8.0-nginx
Failed to read PID from file /run/nginx.pid: Invalid argument
start-container.service: main process exited, code=exited, status=2/INVALIDARGUMENT
Unit start-container.service entered failed state.
start-container.service failed.

docker logs fuel-core-8.0-mcollective
PID file /var/run/mcollective.pid not readable (yet?) after start.

docker logs fuel-core-8.0-ostf
[/usr/lib/systemd/system/ostf.service:2] Unknown lvalue 'Name' in section 'Unit'
[/etc/systemd/system/start-container.service:4] Unknown lvalue 'ConditionFileExecutable' in section 'Unit'
start-container.service: main process exited, code=exited, status=2/INVALIDARGUMENT
Unit start-container.service entered failed state.
start-container.service failed.

docker logs fuel-core-8.0-astute
[/usr/lib/systemd/system/astute.service:2] Unknown lvalue 'Name' in section 'Unit'
[/etc/systemd/system/start-container.service:4] Unknown lvalue 'ConditionFileExecutable' in section 'Unit'
start-container.service: main process exited, code=exited, status=2/INVALIDARGUMENT
Unit start-container.service entered failed state.
start-container.service failed.

docker logs fuel-core-8.0-rsync
PID file /var/run/xinetd.pid not readable (yet?) after start.

docker logs fuel-core-8.0-keystone
[/etc/systemd/system/start-container.service:4] Unknown lvalue 'ConditionFileExecutable' in section 'Unit'

docker logs fuel-core-8.0-postgres
[/etc/systemd/system/start-container.service:4] Unknown lvalue 'ConditionFileExecutable' in section 'Unit'

[Dmitry Teselkin (teselkin-d)]

* ConditionFileExecutable - typo here, should be ConditionFileIsExecutable [1] (link to man page[2])
* Name - invalid key in Unit section, should be Description [3]

[1] https://github.com/openstack/fuel-main/blob/stable/8.0/docker/fuel-centos-build/fuel-centos.ks#L255
[2] https://www.freedesktop.org/software/systemd/man/systemd.directives.html#ConditionFileIsExecutable=
[3] https://github.com/openstack/fuel-library/blob/stable/8.0/deployment/puppet/docker/templates/systemd/template.service.erb#L2

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: master
Change author: Anton Chevychalov <email address hidden>
Review: https://review.fuel-infra.org/29482

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/29482
Submitter: Anton Chevychalov <email address hidden>
Branch: master

Commit: 7ad176e1d6f81fc6ef06de064076bc5564ff3197
Author: Anton Chevychalov <email address hidden>
Date: Wed Jan 18 11:00:11 2017

Fix 8.0 update procedure

There is a bug around lvm, systemd and xfs. So we need
to change update procedure.
Now it reboots master node after update.

Related-Bug: #1642232

Change-Id: Ie59e339d6876264fe463a47061089281acbcdc78

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: stable/8.0
Change author: Anton Chevychalov <email address hidden>
Review: https://review.fuel-infra.org/33149

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/33149
Submitter: Olena Logvinova <email address hidden>
Branch: stable/8.0

Commit: 7afe4081a1276b83f82e50ab71e21a69523bd0e3
Author: Anton Chevychalov <email address hidden>
Date: Tue Apr 25 14:16:42 2017

Fix 8.0 update procedure

There is a bug around lvm, systemd and xfs. So we need
to change update procedure.

Related-Bug: #1642232

Change-Id: I99e20a768f2e9afe31d5a72875373b42ea5dc569