"fuel2 network-template upload" command shows extra file extension in output

Bug #1632316 reported by ElenaRossokhina on 2016-10-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Undecided
Vitalii Kulanov

Bug Description

Detailed bug description:
Command shows result: "Network template <full_file_name_with_ext>.yaml has been uploaded."

Steps to reproduce:
1. Deploy Fuel (e.g. 1 master + 5 nodes).
2. Create new env.
3. Create new network_template_1.yaml file.
4. Try to upload network_template_1.yaml

Expected results:
Network template network_template_1.yaml has been uploaded with info message

Actual result:
I run command several times with the following result
[root@nailgun ~]# ls -la |grep templ
-rw-r--r--. 1 root root 19199 Oct 11 11:23 network_template_1.json
-rw-r--r--. 1 root root 8110 Oct 11 11:22 network_template_1.yaml
[root@nailgun ~]# fuel2 network-template upload -f network_template_1.yaml 1
Network template network_template_1.yaml.yaml has been uploaded.
[root@nailgun ~]# fuel2 network-template upload -f network_template_1.json 1
Network template network_template_1.json.yaml has been uploaded.
[root@nailgun ~]# fuel2 network-template upload -f network_template_1 1
Can't open file 'network_template_1': No such file or directory.

Reproducibility:
10.0 #839

Changed in fuel:
assignee: nobody → Fuel Sustaining (fuel-sustaining-team)
milestone: none → 10.0
Vitalii Kulanov (vitaliy-t) wrote :

@Elena, can you please also attach some network_template files that you are trying to upload?

Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Vitalii Kulanov (vitaliy-t)

Fix proposed to branch: master
Review: https://review.openstack.org/385141

Changed in fuel:
status: New → In Progress

Reviewed: https://review.openstack.org/385141
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=c78c6624b60d7beb11c72b1fd57d5d0acefafc86
Submitter: Jenkins
Branch: master

commit c78c6624b60d7beb11c72b1fd57d5d0acefafc86
Author: tivaliy <email address hidden>
Date: Tue Oct 11 23:21:25 2016 +0300

    Align fuel2 network-template upload procedure

    * removes extra '.yaml' extension from filename
    * makes -f/--file option required

    Change-Id: If1bfe4d9f68331f76ca748281cbc1f609959573d
    Closes-Bug: 1632316

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers