Eslint throws "consistent-return" warnings

Bug #1626059 reported by Julia Aranovich
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Julia Aranovich

Bug Description

npm run lint (npm run eslint) command returns many warnings related to Eslint "consistent-return" rule:

.../fuel-ui/static/tests/functional/pages/login.js
  32:19 warning Expected to return a value at the end of this function consistent-return
  45:19 warning Expected to return a value at the end of this function consistent-return

 They should be fixed.

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (master)

Reviewed: https://review.openstack.org/373362
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=dc54e2ec96dcf558859595cc45490535e897c39f
Submitter: Jenkins
Branch: master

commit dc54e2ec96dcf558859595cc45490535e897c39f
Author: Julia Aranovich <email address hidden>
Date: Tue Sep 20 15:09:19 2016 +0300

    Fix consistent-return warnings

    Closes-Bug: #1626059

    Change-Id: I442f70e7550be4fdd8549095b01f2762fd8bb841

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/374656

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (master)

Reviewed: https://review.openstack.org/374656
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=468dcd1dc4ba5c4135546abb08c81a4c6dcafef2
Submitter: Jenkins
Branch: master

commit 468dcd1dc4ba5c4135546abb08c81a4c6dcafef2
Author: Julia Aranovich <email address hidden>
Date: Thu Sep 22 12:45:18 2016 +0300

    Fix syntax in intern tests

    !A || B logic changed to A && B into functional tests.

    Partial-Bug: #1626059

    Change-Id: I31cfd2145c4fc3f5cf85c51340bee5f734ba0dab

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-ui 10.0.0rc1

This issue was fixed in the openstack/fuel-ui 10.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-ui 10.0.0

This issue was fixed in the openstack/fuel-ui 10.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.