fuel-bootstrap: can't send notification to WebUI

[Alexander Gordeev]

Link to a failed job https://ci.fuel-infra.org/job/master.fuel-agent.pkgs.ubuntu.review_fuel_agent_ironic_deploy/672/

Log contains the following error:
stderr:
Reloading astuted
Trying to execute command: service astute restart
Can't send notification '' to WebUI due to unbound method get_request() must be called with APIClient instance as first argument (got str instance instead)
clean up BuildCommand
Bootstrap image 6474af80-a2ad-45d4-8fb9-bbf83a737a23 has been built: /tmp/6474af80-a2ad-45d4-8fb9-bbf83a737a23.tar.gz
Bootstrap image 6474af80-a2ad-45d4-8fb9-bbf83a737a23 has been activated.

Looks like python-fuelclient is changed, so the following code no longer correct:

https://github.com/openstack/fuel-agent/blob/master/contrib/fuel_bootstrap/fuel_bootstrap_cli/fuel_bootstrap/objects/master_node_settings.py#L32-L34

[Vladimir Kozhukalov (kozhukalov)]

Can't reproduce for 9.2.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/410745

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/410745
Committed: https://git.openstack.org/cgit/openstack/fuel-agent/commit/?id=02b79798451a8d0680313a7ed9af390d114e0896
Submitter: Jenkins
Branch: stable/newton

commit 02b79798451a8d0680313a7ed9af390d114e0896
Author: Vladimir Kozhukalov <email address hidden>
Date: Wed Dec 14 16:18:30 2016 +0300

    Change the way how we instantiate fuel client

    The issue is that in python-fuelclient API has been
    changed and fuelclient.client.APIClient is not available
    anymore. It used to be a singleton of fuel client but
    now it is deprecated. So, let's use APIClient.default_client
    classmethod to instantiate APIClient.

    https://github.com/openstack/python-fuelclient/blob/stable/newton/fuelclient/client.py#L51

    Change-Id: I5287184c6f1c6abf8ac61894db0bd51fbf730401
    Closes-Bug: #1620584

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/430888

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/430888
Committed: https://git.openstack.org/cgit/openstack/fuel-agent/commit/?id=5fa98926f56a3475fcec2726b7327d76a704b776
Submitter: Jenkins
Branch: master

commit 5fa98926f56a3475fcec2726b7327d76a704b776
Author: Vladimir Kozhukalov <email address hidden>
Date: Wed Dec 14 16:18:30 2016 +0300

    Change the way how we instantiate fuel client

    The issue is that in python-fuelclient API has been
    changed and fuelclient.client.APIClient is not available
    anymore. It used to be a singleton of fuel client but
    now it is deprecated. So, let's use APIClient.default_client
    classmethod to instantiate APIClient.

    https://github.com/openstack/python-fuelclient/blob/stable/newton/fuelclient/client.py#L51

    Change-Id: I5287184c6f1c6abf8ac61894db0bd51fbf730401
    Closes-Bug: #1620584
    (cherry picked from commit 02b79798451a8d0680313a7ed9af390d114e0896)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-agent 11.0.0.0rc1 release candidate.

[Vladimir Khlyunev (vkhlyunev)]

1575 - no errors while notifying UI