Fuel for OpenStack

Fix removed None fields in plugin adapters

Bug #1616722 reported by Ilya Kutukov
This bug report is a duplicate of:  Bug #1626855: Plugins are incorrectly updated. Edit Remove
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
In Progress
High
Bulat Gaifullin
Fuel for OpenStack 9.2

Bug Description

When plugin adapter loading data it is removing fields defined as None. This making impossible to make field value empty on update.

Revision history for this message
Dmitry Klenov (dklenov) wrote :

@Ilya, can you please put steps to reproduce? Otherwise it would be difficult for QA folks to verify the issue.

tags: added: area-python
Changed in fuel:
status: New → Incomplete
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/363181

Changed in fuel:
status: Incomplete → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/363800

Revision history for this message
Ilya Kutukov (ikutukov) wrote :

@Dmitriy, now you could use Fuel API to register and update plugin data.

And you can't make None nullable fields like homepage or components_metadata, just no update will occur if you define : null in API request for this fields.

Alexey Shtokolov (ashtokolov)
tags: added: feature-release-as-a-plugin
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (master)

Change abandoned by Ilya Kutukov (<email address hidden>) on branch: master
Review: https://review.openstack.org/363181
Reason: This patch is too heavy to land in 9.1

Revision history for this message
Ilya Kutukov (ikutukov) wrote :

It's related to the known business logic issue, but it's not reachable and reproducible via API because we don't provide plugin update handlers.

Changed in fuel:
milestone: 9.1 → 9.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/378574

Changed in fuel:
assignee: Ilya Kutukov (ikutukov) → Bulat Gaifullin (bgaifullin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/363800
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=c910f056a989f1c7c3149cb62d289dc974beb1c3
Submitter: Jenkins
Branch: master

commit c910f056a989f1c7c3149cb62d289dc974beb1c3
Author: Ilya Kutukov <email address hidden>
Date: Wed Aug 31 19:45:17 2016 +0300

    Empty fields processed correctly in plugin adapters

    Before this patch all empty but existing plugin metadata properties was
    removed from output as well as `tasks` field that was not respecting
    not null constraint at DB level.

    As a minor patch payload missing InvalidFileFormat error was added.

    Change-Id: I6a21e347fefb7a9a30be562b7fb3e4a8c5c61a36
    Partial-Bug: 1616722
    Closes-Bug: 1626855

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/378574
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=222dc9a335739b4f64eed8197993d86dabeeefeb
Submitter: Jenkins
Branch: stable/mitaka

commit 222dc9a335739b4f64eed8197993d86dabeeefeb
Author: Ilya Kutukov <email address hidden>
Date: Wed Aug 31 19:45:17 2016 +0300

    Empty fields processed correctly in plugin adapters

    Before this patch all empty but existing plugin metadata properties was
    removed from output as well as `tasks` field that was not respecting
    not null constraint at DB level.

    As a minor patch payload missing InvalidFileFormat error was added.

    Change-Id: I6a21e347fefb7a9a30be562b7fb3e4a8c5c61a36
    Partial-Bug: 1616722
    Closes-Bug: 1626855

tags: added: in-stable-mitaka
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.