rabbit deployment fails on "check_password"

[Dmitry Burmistrov]

Detailed bug description:
 ISO 9.0
 Sometimes on overloaded or slow systems after service starting there could be some temporary issues with requests to rabbit-server. To avoid such situations "run_with_retries" should also be used for checking password.

 Same change was merged in upstream: https://github.com/puppetlabs/puppetlabs-rabbitmq/pull/499

Steps to reproduce:
 run this manifest:
   include ::osnailyfacter::rabbitmq::rabbitmq
   notify { 'restarting RabbitMQ': } ~> Service <||>
Expected results:
 no errors occurred
Actual result:
 sometimes this error appears: http://paste.openstack.org/show/561447/
Description of the environment:
 Operation system: Ubuntu 14.04

[Ivan Berezovskiy (iberezovskiy)]

Upstream pull request is merged - https://github.com/puppetlabs/puppetlabs-rabbitmq/pull/499
Downstream patch - https://review.fuel-infra.org/#/c/25310/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/360690

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/360690
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=53f95eb5d26d33bda614a8d2430da196e33fbef0
Submitter: Jenkins
Branch: stable/mitaka

commit 53f95eb5d26d33bda614a8d2430da196e33fbef0
Author: dmburmistrov <email address hidden>
Date: Thu Aug 25 20:06:24 2016 +0300

    Switch to bugfixed rabbit module version

    Rabbitmq provider didn't use retries for
    "check_password". On overloaded and slow
    environments it caused failures.

    Fix for this issues is merged in upstream:
      https://github.com/puppetlabs/puppetlabs-rabbitmq/pull/499
    and downstream: https://review.fuel-infra.org/25310

    Related-bug: #1615069

    Change-Id: I79e1aca5cbe81c077705260f0fe9fb30296eb1f4

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/361255

[Andrey Lavrentyev (alavrentyev)]

No errors observed after several reboots on 9.1 snapshot #280

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 495
cat /etc/fuel_build_number:
 495
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0

UBUNTU_MIRROR_ID=ubuntu-2016-09-14-213640
CENTOS_MIRROR_ID=centos-7.2.1511-2016-05-31-083834
MOS_UBUNTU_MIRROR_ID=9.0-2016-09-17-040338
MOS_CENTOS_OS_MIRROR_ID=os-2016-06-23-135731
MOS_CENTOS_PROPOSED_MIRROR_ID=proposed-2016-09-17-040338
MOS_CENTOS_UPDATES_MIRROR_ID=updates-2016-06-23-135916
MOS_CENTOS_HOLDBACK_MIRROR_ID=holdback-2016-06-23-140047
MOS_CENTOS_HOTFIX_MIRROR_ID=hotfix-2016-09-16-084322
MOS_CENTOS_SECURITY_MIRROR_ID=security-2016-06-23-140002

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sergii Golovatiuk (<email address hidden>) on branch: master
Review: https://review.openstack.org/361255