Files should be deleted if package removed

[Dmitry Belyaninov]

Detailed bug description:

[1]
[root@fuel ~]# rpm -ql fuel-nailgun | grep cluster_upgrade
[root@fuel ~]#
[root@fuel ~]# ls /usr/lib/python2.7/site-packages/nailgun/extensions/cluster_upgrade/
alembic_migrations objects tests
[root@fuel ~]# rpm -qf /usr/lib/python2.7/site-packages/nailgun/extensions/cluster_upgrade
file /usr/lib/python2.7/site-packages/nailgun/extensions/cluster_upgrade is not owned by any package

Steps to reproduce:

*install 8.0 (may be 7.0) fuel
*deploy cluster
*prepare octane archives
*install 9.0:
[root@fuel ~]# dd if=/dev/zero of=/dev/vda count=9999 ; sync

virsh reset fuel89_admin;
virsh change-media fuel89_admin sdb --eject;
virsh change-media fuel89_admin sdb --insert /home/tester/iso/MirantisOpenStack-9.0.iso

*setup fuelmenu (vnc)
*update master node:
cat > /etc/yum.repos.d/temporary-0.repo
[temporary-0]
name=temporary-0
baseurl=http://mirror.seed-cz1.fuel-infra.org/mos-repos/centos/mos9.0-centos7/snapshots/proposed-2016-08-19-032321/x86_64
gpgcheck=0

yum update -y
bootstrap_admin_node.sh # fuelmenu- save and quit

*check files/packets [1]

Expected results:
 <put your information here>
Actual result:
 <put your information here>
Reproducibility:
 <put your information here>
Workaround:
 <put your information here>
Impact:
 <put your information here>
Description of the environment:
 Operation system: <put your information here>
 Versions of components: <put your information here>
 Reference architecture: <put your information here>
 Network model: <put your information here>
 Related projects installed: <put your information here>
Additional information:

[root@fuel ~]# yum list fuel-nailgun

Installed Packages
fuel-nailgun.noarch 9.0.0-1.mos8756 @temporary-0

[root@fuel ~]# cat /var/log/yum.log | grep fuel-nailgun
Aug 19 09:21:12 Installed: fuel-nailgun-9.0.0-1.mos8743.noarch
Aug 19 09:39:26 Updated: fuel-nailgun-9.0.0-1.mos8756.noarch

[Ilya Kharin (akscram)]

Such behavior of the fuel-nailgun package can lead to some problems during the upgrade from 9.0 to 9.1 of the Fuel Master node because the package does not remove some of installed files.

[Alexander Tsamutali (astsmtl)]

I think that's because old package used

%files -f %{_builddir}/%{name}-%{version}/nailgun/INSTALLED_FILES

Current package in downstream master branch owns directories properly.

[Roman Vyalov (r0mikiam)]

@dpyzhov why you are assigning this bug to build-team ? (also without moving this bug to New status)
As i understand the problem in the fuel-nailgun spec. moved to mos-packaging

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/360044

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/360655

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/360044
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=41327e9d78f0f808136f1db42c374e9b11884fd4
Submitter: Jenkins
Branch: master

commit 41327e9d78f0f808136f1db42c374e9b11884fd4
Author: Alexander Tsamutali <email address hidden>
Date: Wed Aug 24 21:53:27 2016 +0300

    Cleanup %files section in spec

    Don't use --record during install, don't use -f in %files. Specify
    nailgun files/directories explicitly.

    Change-Id: Ib4adc96fdea1987de08f67ff934a7fa35258f4d1
    Closes-Bug: #1614926

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/360655
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=e7a91afa0ed90a01e22087ec17cbe5cbf06c4d5d
Submitter: Jenkins
Branch: stable/mitaka

commit e7a91afa0ed90a01e22087ec17cbe5cbf06c4d5d
Author: Alexander Tsamutali <email address hidden>
Date: Wed Aug 24 21:53:27 2016 +0300

    Cleanup %files section in spec

    Don't use --record during install, don't use -f in %files. Specify
    nailgun files/directories explicitly.

    Change-Id: Ib4adc96fdea1987de08f67ff934a7fa35258f4d1
    Closes-Bug: #1614926

[Timur Nurlygayanov (tnurlygayanov)]

It is not clear how to verify the issue.

Alexander, could you please describe the steps to verify?

[Alexander Tsamutali (astsmtl)]

Just install the package, write down list of all files _and_ directories that were created, then remove it and check that all files _and_ directories were removed.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 10.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 10.0.0 release.