[LCM] logging task is not idempotent

[Dmitriy Kruglov]

Steps to reproduce:
 1. Deploy a simple env, e.g. 1 controller + 1 compute
 2. Rerun task "logging" against a node

 # Via Fuel CLI
 > fuel node --node-id <node_id> --tasks logging
 # or the direct run of the corresponding puppet manifest on a node
 > puppet apply --noop /etc/puppet/modules/osnailyfacter/modular/logging/logging.pp

Expected result: no resources are changed.
Actual result: some resources are changed.

Below is the trace of task dry run:
# puppet apply --noop /etc/puppet/modules/osnailyfacter/modular/logging/logging.pp
Notice: Scope(Class[Osnailyfacter::Logging::Logging]): MODULAR: logging/logging.pp
Notice: Compiled catalog for node-3.test.domain.local in environment production in 2.42 seconds
Notice: /Stage[main]/Rsyslog::Config/File[/etc/rsyslog.d/49-haproxy.conf]/group: current_value root, should be syslog (noop)
Notice: /etc/rsyslog.d/: Would have triggered 'refresh' from 1 events
Notice: Class[Rsyslog::Config]: Would have triggered 'refresh' from 1 events
Notice: Stage[main]: Would have triggered 'refresh' from 1 events
Notice: Finished catalog run in 2.22 seconds

Description of the environment:
MOS 9.1, snapshot #151

Snapshot details:
UBUNTU_MIRROR_ID=ubuntu-2016-08-03-174238
CENTOS_MIRROR_ID=centos-7.2.1511-2016-05-31-083834
MOS_UBUNTU_MIRROR_ID=9.0-2016-08-17-164322
MOS_CENTOS_OS_MIRROR_ID=os-2016-06-23-135731
MOS_CENTOS_PROPOSED_MIRROR_ID=proposed-2016-08-18-044322
MOS_CENTOS_UPDATES_MIRROR_ID=updates-2016-06-23-135916
MOS_CENTOS_HOLDBACK_MIRROR_ID=holdback-2016-06-23-140047
MOS_CENTOS_HOTFIX_MIRROR_ID=hotfix-2016-07-18-162958
MOS_CENTOS_SECURITY_MIRROR_ID=security-2016-06-23-140002

[Alexey Shtokolov (ashtokolov)]

@Maciej guys, it's a bug in your feature and you had a month to fix it.
Please stop moving bugs right before HCF

[Oleksiy Molchanov (omolchanov)]

MOS-Linux team, can you check why do we provide haproxy.conf for rsyslog from package if we manage it by puppet. From my point of view managing it from puppet is more flexible.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/374749

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/374749
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=87b49f8f9018146bdf26f2cf40be070411f9c75f
Submitter: Jenkins
Branch: master

commit 87b49f8f9018146bdf26f2cf40be070411f9c75f
Author: Oleksiy Molchanov <email address hidden>
Date: Thu Sep 22 15:13:04 2016 +0300

    Added prefix for rsyslog haproxy.conf

    Haproxy config for rsyslog that comes from package changed its name
    from haproxy.conf to 49-haproxy.conf [1]. As we are overwriting this
    file we should rename it too.

    [1]. https://review.fuel-infra.org/gitweb?p=packages/trusty/haproxy.git;a=blob;f=debian/rules;h=cda13edca7f475f7292e03f8fc6859663b37d90b;hb=refs/heads/9.0#l66

    Change-Id: I4683e28d0f3bb1ed3f5135ff73b9fdeeef1215cf
    Closes-Bug: 1614895

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/384894

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-library 10.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/384894
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=4e560f0758d311bd924280cbfff8b8761fbfc554
Submitter: Jenkins
Branch: stable/mitaka

commit 4e560f0758d311bd924280cbfff8b8761fbfc554
Author: Oleksiy Molchanov <email address hidden>
Date: Thu Sep 22 15:13:04 2016 +0300

    Added prefix for rsyslog haproxy.conf

    Haproxy config for rsyslog that comes from package changed its name
    from haproxy.conf to 49-haproxy.conf [1]. As we are overwriting this
    file we should rename it too.

    [1]. https://review.fuel-infra.org/gitweb?p=packages/trusty/haproxy.git;a=blob;f=debian/rules;h=cda13edca7f475f7292e03f8fc6859663b37d90b;hb=refs/heads/9.0#l66

    Change-Id: I4683e28d0f3bb1ed3f5135ff73b9fdeeef1215cf
    Closes-Bug: 1614895
    (cherry picked from commit 87b49f8f9018146bdf26f2cf40be070411f9c75f)

[ElenaRossokhina (esolomina)]

Verified on 9.2 snapshot#533

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-library 10.0.0 release.