Broken validation for empty dns list

[guochunting]

Detailed bug description:
  I let external dns blank when installing fuel 9.0, then create an openstack environment , can not get the "+" button in Openstack environment Network-Settings-Other-Host OS DNS Server.
Steps to reproduce:
  1. Install Fuel 9.0 with empty external empty dns.
  2. Create a new Openstack environment in fuel web UI.
  3. enter into page: Network-Settings-Other, i cannot get the "+" button to add dns servers
  4. make some modification in setttings ,then save.

Expected results:
  without any error.
  Or
  got the "+" button to add some dns servers

Actual result:
   no "+" button to add dns server
  and
  there is an error
    OpenStack Settings Configuration Error
    [dns_list] None is not of type 'array' Failed validating 'type' in schema['properties'] ['value']: {'items': {'type':'string'}, 'minItem': 1, 'type': 'array'} On instance['value']:None

[Julia Aranovich (jkirnosova)]

According to schema dns_list should be an array and contain at least 1 item.
So, user should not be able to leave dns list blank during installation.

Or the schema should be changed accordingly to allow user not to set dns list.

[Dmitry Klenov (dklenov)]

Found in one of customer's environments, setting 'customer-found' tag.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/389195

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/389664

[Vladimir Kozhukalov (kozhukalov)]

related fix https://review.openstack.org/#/c/389664/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/389195
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=bb6b3605b508e5caf68ef2d6c90bb0c94be98e62
Submitter: Jenkins
Branch: stable/mitaka

commit bb6b3605b508e5caf68ef2d6c90bb0c94be98e62
Author: Vladimir Kozhukalov <email address hidden>
Date: Thu Oct 20 16:18:15 2016 +0300

    Expose add botton when text_list is empty

    The issue is that when a text_list is empty
    there is nothing to render including 'add'
    and 'delete' buttons. We should provide the
    possibility to add items when the list is empty.

    Change-Id: I991ec3a885a6462f4a8afd7f96591fd7ec82a0b4
    Closes-Bug: #1613614

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/391742

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/391757

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/391758

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/391760

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/391761

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/391763

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/391763
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=229bd818059f793e272fb97feefa7631fe6dc0b7
Submitter: Jenkins
Branch: stable/mitaka

commit 229bd818059f793e272fb97feefa7631fe6dc0b7
Author: Julia Aranovich <email address hidden>
Date: Mon Oct 31 12:12:09 2016 +0300

    Fix styles of text_list setting with empty value

    * fixed Add Value button margins
    * fixed description layout
    * DNS nameservers min=1 limit restored

    Partial-Bug: #1613614

    Change-Id: Idc175e3f629674e764a3921ef2f85e3278131cba

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/391761
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=b3718711a0ad58ace253397ebc9645ce40858582
Submitter: Jenkins
Branch: master

commit b3718711a0ad58ace253397ebc9645ce40858582
Author: Vladimir Kozhukalov <email address hidden>
Date: Thu Oct 20 16:18:15 2016 +0300

    Expose add botton when text_list is empty

    The issue is that when a text_list is empty
    there is nothing to render including 'add'
    and 'delete' buttons. We should provide the
    possibility to add items when the list is empty.

    Change-Id: I991ec3a885a6462f4a8afd7f96591fd7ec82a0b4
    Closes-Bug: #1613614
    (cherry picked from commit bb6b3605b508e5caf68ef2d6c90bb0c94be98e62)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/392132

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/392132
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=c16a8d46e03a3f8282303558d10d02e1b870db02
Submitter: Jenkins
Branch: master

commit c16a8d46e03a3f8282303558d10d02e1b870db02
Author: Julia Aranovich <email address hidden>
Date: Mon Oct 31 12:12:09 2016 +0300

    Fix styles of text_list setting with empty value

    * fixed Add Value button margins
    * fixed description layout
    * DNS nameservers min=1 limit restored

    Partial-Bug: #1613614

    Change-Id: Idc175e3f629674e764a3921ef2f85e3278131cba

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/391742
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=670d71fb92e59e592b8f5c4a9108da5c5dac96d1
Submitter: Jenkins
Branch: stable/mitaka

commit 670d71fb92e59e592b8f5c4a9108da5c5dac96d1
Author: Julia Aranovich <email address hidden>
Date: Mon Oct 31 11:18:59 2016 +0300

    Forbid empty value for NTP server list

    Default minimum of values in text_list setting value list
    was changed from 1 to 0 here: https://review.openstack.org/#/c/389195/
    So, min=1 limit should be restored
    for "NTP server list" setting not to change its functionality.

    Related-Bug: #1613614

    Change-Id: If354f86c5cd11fe7eb0dc07c7c4d1048dcb75363

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/389664
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=02927123f4081d2589281cedd5bb54074d7affed
Submitter: Jenkins
Branch: stable/mitaka

commit 02927123f4081d2589281cedd5bb54074d7affed
Author: Vladimir Kozhukalov <email address hidden>
Date: Fri Oct 21 14:11:47 2016 +0300

    text_list attributes could be empty

    The issue is that sometimes users want
    to be able to have emtpy lists for
    some attributes like for example upstream
    dns.

    Change-Id: Ib96b0cb051892e50f26a46ce33eeb477ef2a36f1
    Related-Bug: #1613614

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/394350

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/394350
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=7f7c2a526e764b9027e0d1befd1f913173f494ea
Submitter: Jenkins
Branch: master

commit 7f7c2a526e764b9027e0d1befd1f913173f494ea
Author: Julia Aranovich <email address hidden>
Date: Mon Oct 31 11:18:59 2016 +0300

    Forbid empty value for NTP server list

    Default minimum of values in text_list setting value list
    was changed from 1 to 0 here: https://review.openstack.org/#/c/389195/
    So, min=1 limit should be restored
    for "NTP server list" setting not to change its functionality.

    Related-Bug: #1613614

    Change-Id: If354f86c5cd11fe7eb0dc07c7c4d1048dcb75363
    (cherry picked from commit 670d71fb92e59e592b8f5c4a9108da5c5dac96d1)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/391760
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=f202c4cc29eb0081d79923208d074fbf5b0c3741
Submitter: Jenkins
Branch: stable/newton

commit f202c4cc29eb0081d79923208d074fbf5b0c3741
Author: Vladimir Kozhukalov <email address hidden>
Date: Thu Oct 20 16:18:15 2016 +0300

    Expose add botton when text_list is empty

    The issue is that when a text_list is empty
    there is nothing to render including 'add'
    and 'delete' buttons. We should provide the
    possibility to add items when the list is empty.

    Change-Id: I991ec3a885a6462f4a8afd7f96591fd7ec82a0b4
    Closes-Bug: #1613614
    (cherry picked from commit bb6b3605b508e5caf68ef2d6c90bb0c94be98e62)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/396588

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/396594

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/396588
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=ef5969399cbd9eff88a88d3ff71a254fe2c907ce
Submitter: Jenkins
Branch: stable/newton

commit ef5969399cbd9eff88a88d3ff71a254fe2c907ce
Author: Julia Aranovich <email address hidden>
Date: Mon Oct 31 12:12:09 2016 +0300

    Fix styles of text_list setting with empty value

    * fixed Add Value button margins
    * fixed description layout
    * DNS nameservers min=1 limit restored

    Partial-Bug: #1613614

    Change-Id: Idc175e3f629674e764a3921ef2f85e3278131cba
    (cherry picked from commit c16a8d46e03a3f8282303558d10d02e1b870db02)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/396594
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=cc14adae6774d0c896e752ce0a124e23d643ff0d
Submitter: Jenkins
Branch: stable/newton

commit cc14adae6774d0c896e752ce0a124e23d643ff0d
Author: Julia Aranovich <email address hidden>
Date: Mon Oct 31 11:18:59 2016 +0300

    Forbid empty value for NTP server list

    Default minimum of values in text_list setting value list
    was changed from 1 to 0 here: https://review.openstack.org/#/c/391760/
    So, min=1 limit should be restored
    for "NTP server list" setting not to change its functionality.

    Related-Bug: #1613614

    Change-Id: If354f86c5cd11fe7eb0dc07c7c4d1048dcb75363
    (cherry picked from commit 670d71fb92e59e592b8f5c4a9108da5c5dac96d1)
    (cherry picked from commit 7f7c2a526e764b9027e0d1befd1f913173f494ea)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/391757
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=f548c96209b003d990c46a4e38e05715d952ca72
Submitter: Jenkins
Branch: stable/newton

commit f548c96209b003d990c46a4e38e05715d952ca72
Author: Vladimir Kozhukalov <email address hidden>
Date: Fri Oct 21 14:11:47 2016 +0300

    text_list attributes could be empty

    The issue is that sometimes users want
    to be able to have emtpy lists for
    some attributes like for example upstream
    dns.

    Change-Id: Ib96b0cb051892e50f26a46ce33eeb477ef2a36f1
    Related-Bug: #1613614

[Dmitry Belyaninov (dbelyaninov)]

Verified on snapshot #585

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-ui 11.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/391758
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=4f307da77164735c7261ea6f727fbc7d79ca1767
Submitter: Jenkins
Branch: master

commit 4f307da77164735c7261ea6f727fbc7d79ca1767
Author: Vladimir Kozhukalov <email address hidden>
Date: Fri Oct 21 14:11:47 2016 +0300

    text_list attributes could be empty

    The issue is that sometimes users want
    to be able to have emtpy lists for
    some attributes like for example upstream
    dns.

    Change-Id: Ib96b0cb051892e50f26a46ce33eeb477ef2a36f1
    Related-Bug: #1613614