Fuel for OpenStack

generate_vms.sh is not idempotent

Bug #1613241 reported by Dmitry Ukov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Maksim Malchuk
Fuel for OpenStack 10.0
Mitaka
Fix Released
Medium
Maksim Malchuk
Fuel for OpenStack 9.1

Bug Description

If generate_vms.sh fails on start vm (for example due to network misconfiguration) we never get vm started due to libvirt doamin stays defined. See:
https://github.com/openstack/fuel-library/blob/master/files/fuel-misc/generate_vms.sh#L97

Tags: area-library
Dmitry Guryanov (dguryanov)
Changed in fuel:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Fuel Sustaining (fuel-sustaining-team)
milestone: none → 10.0
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
importance: High → Medium
Maksim Malchuk (mmalchuk)
tags: added: area-library
Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Maksim Malchuk (mmalchuk)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/362817

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/362306
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=bbbb73b42428c07e91b7e580417f1a83cac4bb2c
Submitter: Jenkins
Branch: master

commit bbbb73b42428c07e91b7e580417f1a83cac4bb2c
Author: Maksim Malchuk <email address hidden>
Date: Mon Aug 29 20:54:16 2016 +0300

    Make snapshots for 'reduced_footprint' on request

    Related-Bug: #1613241
    Change-Id: I5d638a1875686e04658676d927013ee9202c69b6
    Signed-off-by: Maksim Malchuk <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/362949

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/mitaka)

Reviewed: https://review.openstack.org/362949
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=73ca52d4f7eae85a0bd422b44479ec86a969b2fc
Submitter: Jenkins
Branch: stable/mitaka

commit 73ca52d4f7eae85a0bd422b44479ec86a969b2fc
Author: Maksim Malchuk <email address hidden>
Date: Tue Aug 30 15:15:06 2016 +0300

    Fix 'generate_vms.sh' idempotentency

    This change fixes 'generate_vms.sh' idempotentency by undefining the
    domain on error, and also adds command execution output to the logs.

    Change-Id: I94a9b1340a521da2bbfd1c08d7e1e0dc47aa9f51
    Closes-Bug: #1613241
    Signed-off-by: Maksim Malchuk <email address hidden>

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/362817
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=a5d458ff7968dbe419055615975b69b79c321e7e
Submitter: Jenkins
Branch: master

commit a5d458ff7968dbe419055615975b69b79c321e7e
Author: Maksim Malchuk <email address hidden>
Date: Tue Aug 30 15:15:06 2016 +0300

    Fix 'generate_vms.sh' idempotentency

    This change fixes 'generate_vms.sh' idempotentency by undefining the
    domain on error, and also adds command execution output to the logs.

    Change-Id: I94a9b1340a521da2bbfd1c08d7e1e0dc47aa9f51
    Closes-Bug: #1613241
    Signed-off-by: Maksim Malchuk <email address hidden>

TatyanaGladysheva (tgladysheva)
tags: added: on-verification
Revision history for this message
TatyanaGladysheva (tgladysheva) wrote :

Verified on 9.1 snapshot #292.

tags: removed: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-library 10.0.0rc1

This issue was fixed in the openstack/fuel-library 10.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-library 10.0.0

This issue was fixed in the openstack/fuel-library 10.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.