[nailgun][python-fuelclient] Nailgun reports 400 Client Error: Bad Request while executing 'fuel2 task history show'

Bug #1610177 reported by Vitalii Kulanov
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Vitalii Kulanov
Mitaka
Fix Released
High
Alexey Shtokolov

Bug Description

Detailed bug description:
While executing 'fuel2 task history show' command Nailgun reports 400 Client Error: Bad Request:

[root@fuel ~]# fuel2 task history show 7
400 Client Error: Bad Request for url: http://10.20.0.2:8000/api/v1/transactions/7/deployment_history/?nodes=&statuses=&tasks_names= (Statuses parameter could be only: pending, ready, running, error, skipped)

Steps to reproduce:
1. Deploy Fuel (e.g. 1 master + 5 nodes).
2. Create new env.
3. Add two nodes with 'controller' and 'compute' roles:
4. Start deploying.
6. Try to get information about deployment tasks and their statuses through python-fuelclient:
   [root@fuel ~]# fuel2 task list
+----+---------+------------+---------+--------+----------+
| id | status | name | cluster | result | progress |
+----+---------+------------+---------+--------+----------+
| 1 | ready | provision | 1 | {} | 100 |
| 2 | ready | dump | None | {} | 100 |
| 3 | ready | provision | 1 | {} | 100 |
| 4 | running | deploy | 1 | {} | 80 |
| 7 | running | deployment | 1 | {} | 80 |
+----+---------+------------+---------+--------+----------+
[root@fuel ~]# fuel2 task history show 7
400 Client Error: Bad Request for url: http://10.20.0.2:8000/api/v1/transactions/7/deployment_history/?nodes=&statuses=&tasks_names= (Statuses parameter could be only: pending, ready, running, error, skipped)

Expected results:
The result table with respective tasks and their statuses

Actual result:
400 Client Error: Bad Request for url: http://10.20.0.2:8000/api/v1/transactions/7/deployment_history/?nodes=&statuses=&tasks_names= (Statuses parameter could be only: pending, ready, running, error, skipped)

Reproducibility:
 Always

Description of the environment:
[root@fuel ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 481
cat /etc/fuel_build_number:
 481
cat /etc/fuel_release:
 10.0
cat /etc/fuel_openstack_version:
 newton-10.0

Additional information:
The cause of this issue is commit to Nailgun (https://github.com/openstack/fuel-web/commit/c179e5d0b4b8a5b4566120eceb81a1d0ed9577c8), so python-fuelclient should be aligned.

Changed in fuel:
assignee: nobody → Vitalii Kulanov (vitaliy-t)
tags: added: module-client
removed: module-astute module-nailgun
Changed in fuel:
status: New → Confirmed
importance: Undecided → High
milestone: none → 9.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/355600

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Vladimir Kuklin (vkuklin) wrote :

We need to support this in 9.1 as well

Dmitry Pyzhov (dpyzhov)
no longer affects: fuel/newton
tags: added: swarm-fail
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/355600
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=ec2ed50acb710ab4b1b8f049f6118a3e88a4004b
Submitter: Jenkins
Branch: master

commit ec2ed50acb710ab4b1b8f049f6118a3e88a4004b
Author: tivaliy <email address hidden>
Date: Mon Aug 15 21:40:39 2016 +0300

    Align filter params for deployment history command

    After the commit c179e5d0b4b8a5b4566120eceb81a1d0ed9577c8
    GET request to Nailgun should not contain parameters
    with empty values, e.g. /?param=&param1=&param2.
    This patch aligns 'fuel2 task history show' command
    execution removing empty parameters from GET requet

    Change-Id: I04f02767c45691dc4345bd73d1cc3fb3d7bd4852
    Closes-Bug: 1610177

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/364305

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (stable/mitaka)

Reviewed: https://review.openstack.org/364305
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=908ca5cc6bbd39402ab040266b8e1573c4894b50
Submitter: Jenkins
Branch: stable/mitaka

commit 908ca5cc6bbd39402ab040266b8e1573c4894b50
Author: tivaliy <email address hidden>
Date: Mon Aug 15 21:40:39 2016 +0300

    Align filter params for deployment history command

    After the commit c179e5d0b4b8a5b4566120eceb81a1d0ed9577c8
    GET request to Nailgun should not contain parameters
    with empty values, e.g. /?param=&param1=&param2.
    This patch aligns 'fuel2 task history show' command
    execution removing empty parameters from GET requet

    Change-Id: I04f02767c45691dc4345bd73d1cc3fb3d7bd4852
    Closes-Bug: 1610177
    (cherry picked from commit ec2ed50acb710ab4b1b8f049f6118a3e88a4004b)

tags: added: on-verification
Revision history for this message
TatyanaGladysheva (tgladysheva) wrote :

Verified on 9.1 snapshot #226.

tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.