Problem with mapping of custom networks to interfaces

[Dmitry Dmitriev]

Detailed bug description: custom networks created by fuel network-group --create can not be mapped to network interfaces using Fuel UI. Screenshot of error window is attached. Problem is actual for Fuel 8 MU2 and not for vanilla Fuel 8.

Steps to reproduce:

- install Fuel 8
- install Fuel 8 MU2
- create env
- create nodes, map networks
- !!do not deploy changes!!
- create custom networks using fuel network-group --create
- try to map networks to interfaces on nodes in "Pending Addition" state

Expected results: custom networks are showed by Fuel UI and can be mapped to network interfaces.

Actual result: custom networks aren't showed by Fuel UI but any changes can not be saved due to error.

Reproducibility: every time

Workaround: use network template

Impact: user can not deploy clouds with custom networks

Description of the environment:
 Operation system: Ubuntu 14.04
 Versions of components: Fuel 8 MU2
 Network model: neutron

[Anton Chevychalov (achevychalov)]

Unable to reproduce problem in test environment. Could you please provide more information about your actions.

Perhaps there is issue with exact custom network. It would be helpful to have exact parameters of custom network.

[Anton Chevychalov (achevychalov)]

New information about steps to reproduce problem (after talking with Dmitry):

- install Fuel 8
- install Fuel 8 MU2
- create env
- create nodes, map networks
- !!do not deploy changes!!
- create custom networks using fuel network-group --create
- try to map networks to interfaces on nodes in "Pending Addition" state.

[Anton Chevychalov (achevychalov)]

Bug confirmed for MOS 8.0 and MOS 9.0

[Aleksey Kasatkin (alekseyk-ru)]

Now Fuel API insists on adding of all available networks to nodes' interfaces.

https://github.com/openstack/fuel-web/blob/193f9aef7f7448536c828179b16bc27862218772/nailgun/nailgun/extensions/network_manager/validators/network.py#L937

It can be done via CLI now. But it's not always needed to have all the networks mapped on every node. So, it would be better to check presence on required network roles on nodes instead. Now, presence of required network roles on nodes is checked before deployment (it is done for network templates case but I'm not sure whether it is done for case w/o templates).

So, it's needed to change the rule to make setup more user-friendly from:

- all nodes must have all available networks assigned

to

- all nodes must have all required network roles assigned (different node roles require different sets of network roles).

To check network roles is slightly more complicated task as we need to walk through one more link: node -> interface -> network -> network role.

Probably, this check will be much slower than current validation. Then, it can be done not in NodeNICsHandler but during "Network Verification" procedure and before deployment (to not slow down networks-to-interfaces assignment).

[Aleksey Kasatkin (alekseyk-ru)]

UI could be improved too: it would be great to have an ability to see and map all the available networks. AFAIR, CLI supports this already.

[Julia Aranovich (jkirnosova)]

Nailgun part of the fix is moved to a separate bug https://bugs.launchpad.net/fuel/+bug/1641082

Within current ticket UI need to be extended to support allocation of unassigned networks to interfaces.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/397718

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/397718
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=cff512b7ad215293d67f7568975b7ff781572ddf
Submitter: Jenkins
Branch: master

commit cff512b7ad215293d67f7568975b7ff781572ddf
Author: Julia Aranovich <email address hidden>
Date: Tue Nov 15 10:58:37 2016 +0300

    Unassigned networks on interfaces configuration screen

    Closes-Bug: #1606177

    Change-Id: I211fa81474d5f511584924e3ab2dae956930f1f1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/399500

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/399500
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=5f54c950d7a63ef3141953f58262dd1a96b78fd1
Submitter: Jenkins
Branch: stable/newton

commit 5f54c950d7a63ef3141953f58262dd1a96b78fd1
Author: Julia Aranovich <email address hidden>
Date: Tue Nov 15 10:58:37 2016 +0300

    Unassigned networks on interfaces configuration screen

    Closes-Bug: #1606177

    Change-Id: I211fa81474d5f511584924e3ab2dae956930f1f1
    (cherry picked from commit cff512b7ad215293d67f7568975b7ff781572ddf)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/399580

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/399580
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=453b244e0f2f7e5633772f7f122ca9bf6006133f
Submitter: Jenkins
Branch: stable/mitaka

commit 453b244e0f2f7e5633772f7f122ca9bf6006133f
Author: Julia Aranovich <email address hidden>
Date: Tue Nov 15 10:58:37 2016 +0300

    Unassigned networks on interfaces configuration screen

    Closes-Bug: #1606177

    Change-Id: I211fa81474d5f511584924e3ab2dae956930f1f1

[Ekaterina Shutova (eshutova)]

Verified on 9.2 snapshot #556.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-ui 11.0.0.0rc1 release candidate.

[Anton Chevychalov (achevychalov)]

That patch too big to be ported on MOS 8 and older.