Fuel for OpenStack

python-fuelclient test doesn't fail on errors in code

Bug #1604868 reported by Elena Kosareva
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Critical
Roman Prykhodchenko
Fuel for OpenStack 10.0

Bug Description

cliff doesn't raise python errors and all test mark as PASSED even if python code raise exceptions

Steps to reproduce:
run tox for python-fuelclient and check tests stdout. In tests output will be smth like:
2016-07-13 12:31:25.949928 | {0} fuelclient.tests.unit.v2.cli.test_node.TestNodeCommand.test_node_vms_conf_create_fail [0.007624s] ... ok
2016-07-13 12:31:25.949954 |
2016-07-13 12:31:25.949972 | Captured stderr:
2016-07-13 12:31:25.949993 | ~~~~~~~~~~~~~~~~
2016-07-13 12:31:25.950014 | 'NoneType' object is not iterable

See original description
Elena Kosareva (ekosareva)
description: updated
affects: mos → fuel
Changed in fuel:
assignee: nobody → Romcheg (romcheg-prihod)
Roman Prykhodchenko (romcheg)
Changed in fuel:
assignee: Romcheg (romcheg-prihod) → Roman Prykhodchenko (romcheg)
importance: Undecided → Critical
status: New → Confirmed
milestone: none → 10.0
tags: added: area-python
OpenStack Infra (hudson-openstack)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/344886
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=79f96f3dbcd988c06d15c83e6ac90372bc536455
Submitter: Jenkins
Branch: master

commit 79f96f3dbcd988c06d15c83e6ac90372bc536455
Author: Roman Prykhodchenko <email address hidden>
Date: Wed Jul 20 17:21:19 2016 +0200

    Run commands with --debug in tests

    This is required for cliff to not mute exceptions. This patch
    also fixes all problems that were hidden by the bug.

    Closes-bug: #1604868
    Change-Id: Id90d6bd6f62b7cb6ca48a0a4af64999d322f53b6

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/377971

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (stable/mitaka)

Reviewed: https://review.openstack.org/377971
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=81d1905c00d3c4522f08849a39b2c5a730bb1093
Submitter: Jenkins
Branch: stable/mitaka

commit 81d1905c00d3c4522f08849a39b2c5a730bb1093
Author: Roman Prykhodchenko <email address hidden>
Date: Wed Jul 20 17:21:19 2016 +0200

    Run commands with --debug in tests

    This is required for cliff to not mute exceptions. This patch
    also fixes all problems that were hidden by the bug.

    Closes-bug: #1604868
    Change-Id: Id90d6bd6f62b7cb6ca48a0a4af64999d322f53b6

tags: added: in-stable-mitaka
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.