fuel-devops default template containg deprecated parameter "tag" for private-pool1 instead of range of vlans

[Artem Hrechanychenko]

Detailed bug description:

private-pool01 in default.yaml devops template contain deprecated parameter "tag"

https://github.com/openstack/fuel-devops/blob/master/devops/templates/default.yaml#L77
                   ^^^^
private-pool01:
        net: *pool_default
        params:
          tag: 103

And it's leads to fail of cluster deploying with HTTP 400 because END of VLAND RANGE == NONE

Steps to reproduce:
start any system test with deploying any cluster and export next ENV variable:

DEVOPS_SETTINGS_TEMPLATE=default.yaml

Expected results:
test passed

Actual result:
test failed on network verify task
Run network verification on the cluster 1
2016-07-20 10:15:42,442 - ERROR __init__.py:66 -- verify_networks raised: BadRequest('Bad Request (HTTP 400)',)
Traceback: Traceback (most recent call last):
 File "/home/agrechanichenko/fuel-qa/fuelweb_test/__init__.py", line 59, in wrapped
   result = func(*args, **kwargs)
 File "/home/agrechanichenko/fuel-qa/fuelweb_test/models/nailgun_client.py", line 108, in verify_networks
   json=self.get_networks(cluster_id)
 File "/home/agrechanichenko/fuel-qa/fuelweb_test/models/nailgun_client.py", line 85, in _put
   return self.session.put(url=url, **kwargs)
 File "/home/agrechanichenko/venv-nailgun-tests-3.0/local/lib/python2.7/site-packages/keystoneauth1/session.py", line 672, in put
   return self.request(url, 'PUT', **kwargs)
 File "/home/agrechanichenko/venv-nailgun-tests-3.0/local/lib/python2.7/site-packages/positional/__init__.py", line 101, in inner
   return wrapped(*args, **kwargs)
 File "/home/agrechanichenko/venv-nailgun-tests-3.0/local/lib/python2.7/site-packages/keystoneauth1/session.py", line 559, in request
   raise exceptions.from_response(resp, method, url)
BadRequest: Bad Request (HTTP 400)

[root@nailgun ~]# fuel network --env-id 1 --verify
400 Client Error: Bad Request for url: http://10.109.21.2:8000/api/v1/clusters/1/network_configuration/neutron/verify (None is not of type 'integer'Failed validating 'type' in schema['properties']['networking_parameters']['properties']['vlan_range']['items']:
   {'exclusiveMaximum': False,
    'exclusiveMinimum': False,
    'maximum': 4094,
    'minimum': 2,
    'type': 'integer'}On instance['networking_parameters']['vlan_range'][1]:
   None)

Reproducibility:
every time

Workaround:

need to change to "tag" to vlan_start_end

private-pool01:
       net: *pool_default
       params:
         vlan_start: 960
         vlan_end: 1000

[Dennis Dmitriev (ddmitriev)]

YAML template examples should be updated in fuel-devops repo.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/344738

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/344738
Committed: https://git.openstack.org/cgit/openstack/fuel-devops/commit/?id=4e8f54cf25c86cbd87fbb98c781a9c7b61417f8a
Submitter: Jenkins
Branch: master

commit 4e8f54cf25c86cbd87fbb98c781a9c7b61417f8a
Author: Artem Grechanichenko <email address hidden>
Date: Wed Jul 20 13:55:03 2016 +0300

    Change tag to vlan_start vlan_end range in devops templates

    Change-Id: I3c9b1abbb51af436546968573d25397332fd7c97
    Closes-Bug: #1604771