Ironic dbsync should be executed only on primary controller

[Denis Egorenko]

Ironic-conductor node tries to execute db-sync and fails. Db sync should be executed only on primary controller (https://github.com/openstack/fuel-library/blob/master/deployment/puppet/openstack_tasks/manifests/ironic/ironic.pp#L88)

2016-07-12 13:49:43 ERR (/Stage[main]/Ironic::Db::Sync/Exec[ironic-dbsync]) ironic-dbsync --config-file /etc/ironic/ironic.conf returned 1 instead of one of [0]
2016-07-12 13:49:43 ERR (/Stage[main]/Ironic::Db::Sync/Exec[ironic-dbsync]) Failed to call refresh: ironic-dbsync --config-file /etc/ironic/ironic.conf returned 1 instead of one of [0]

Steps to reproduce:

1. Get ISO: #597
2. Nodes = 6
    Conroller + Mongo = 3
    Compute + Cinder = 2
    Ironic = 1
    Neutron DVR
    Nova quotas
    Cinder LVM over iSCSI for volumes
    OpenStack debug logging
    Install Sahara
    Install Ceilometer and Aodh
    Install Ironic

Expected result: no any errors.

Actual result: failed to sync database on ironic node.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/341014

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/341014
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=94483a3a158be21de2742c407380d0457044f245
Submitter: Jenkins
Branch: master

commit 94483a3a158be21de2742c407380d0457044f245
Author: Denis Egorenko <email address hidden>
Date: Tue Jul 12 18:43:24 2016 +0300

    Do not run db sync on ironic conductor node

    Dbsync should be executed on primary controller, but now it is also
    running on ironic-conductor node, because ironic main class has
    sync_db by default true.

    Change-Id: I91319115d3a58baa218c55f3330f147d67c0f5f8
    Closes-bug: #1602324

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/343565

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/343565
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=4e93c8248ad323c269ec4a1203426cd145baeea6
Submitter: Jenkins
Branch: stable/mitaka

commit 4e93c8248ad323c269ec4a1203426cd145baeea6
Author: Denis Egorenko <email address hidden>
Date: Tue Jul 12 18:43:24 2016 +0300

    Do not run db sync on ironic conductor node

    Dbsync should be executed on primary controller, but now it is also
    running on ironic-conductor node, because ironic main class has
    sync_db by default true.

    Change-Id: I91319115d3a58baa218c55f3330f147d67c0f5f8
    Closes-bug: #1602324
    (cherry picked from commit 94483a3a158be21de2742c407380d0457044f245)

[Kyrylo Romanenko (kromanenko)]

Environment successfully deployed with following packages revision for Sep 4, 2016:
http://paste.openstack.org/show/566871/

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-library 10.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-library 10.0.0 release.