Setting up deployed_before in generated cluster attributes

Bug #1602281 reported by Rodion Tikunov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Invalid
Critical
Fuel Sustaining
5.1.x
Confirmed
Critical
Rodion Tikunov
6.0.x
Confirmed
Critical
Rodion Tikunov
6.1.x
Confirmed
Critical
Rodion Tikunov
7.0.x
In Progress
Critical
Rodion Tikunov

Bug Description

Detailed bug description:
This bug related with https://bugs.launchpad.net/fuel/+bug/1529691
Environments <8.0 need to set attribute "deployed_before": {"value": true} in generated cluster attributes after successful deploy.

Steps to reproduce:
1. Deploy any environment (1 controller and 1 compute nodes)
2. Connect to nailgun database and make query:
nailgun=# select generated from attributes;

Expected results:
"deployed_before": {"value": true}

Expected results:
"deployed_before": {"value": false} or even attribute doesn't exist

Impact:
The bug mentioned in the description could not be fixed without this attribute.

Additional information:
Affects all versions <8.0

Tags: area-python
Changed in fuel:
milestone: 7.0-updates → 7.0-mu-5
Changed in fuel:
importance: Undecided → Critical
Dmitry Klenov (dklenov)
Changed in fuel:
assignee: nobody → Fuel Sustaining (fuel-sustaining-team)
status: New → Confirmed
tags: added: area-python
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 7.0-mu-5 → 10.0
status: Confirmed → Invalid
Revision history for this message
Rodion Tikunov (rtikunov) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/7.0)

Reviewed: https://review.openstack.org/340827
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=2b0efd5eeb42431e03692f658792187b313083ea
Submitter: Jenkins
Branch: stable/7.0

commit 2b0efd5eeb42431e03692f658792187b313083ea
Author: Artem Roma <email address hidden>
Date: Tue Mar 15 12:37:07 2016 +0200

    Set 'deployed_before' attribute in cluster attributes if not present

    Before this change if master node had been upgraded to Fuel of
    versions >= 8.0, attempt to re/deploy existing clusters would have failed
    as attributes of those clusters would have lack 'deployed_before' field.

    Since processing of the flag is temporary solution it should not be
    coded in data base migration logic. Thus the change introduces creating
    of the attribute with given value if it is not already present.

    Conflicts:
     nailgun/nailgun/test/unit/test_objects.py

    Change-Id: I302ddb340d2ecf14b1fa414fda71aa7f32363bdf
    Closes-Bug: #1602281
    Related-Bug: #1529691
    (cherry picked from commit 48ee65f15e346cff46e0bf0cfba9dbe9afe43528)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/6.1)

Fix proposed to branch: stable/6.1
Review: https://review.openstack.org/342855

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/6.1)

Reviewed: https://review.openstack.org/342855
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=e4d09ec013843058837af395ba3db5d63a063a62
Submitter: Jenkins
Branch: stable/6.1

commit e4d09ec013843058837af395ba3db5d63a063a62
Author: Artem Roma <email address hidden>
Date: Tue Mar 15 12:37:07 2016 +0200

    Set 'deployed_before' attribute in cluster attributes if not present

    Before this change if master node had been upgraded to Fuel of
    versions >= 8.0, attempt to re/deploy existing clusters would have failed
    as attributes of those clusters would have lack 'deployed_before' field.

    Since processing of the flag is temporary solution it should not be
    coded in data base migration logic. Thus the change introduces creating
    of the attribute with given value if it is not already present.

    Conflicts:
     nailgun/nailgun/test/unit/test_objects.py

    Change-Id: I302ddb340d2ecf14b1fa414fda71aa7f32363bdf
    Closes-Bug: #1602281
    Related-Bug: #1529691
    (cherry picked from commit 48ee65f15e346cff46e0bf0cfba9dbe9afe43528)
    (cherry picked from commit 2b0efd5eeb42431e03692f658792187b313083ea)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (stable/6.0)

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: stable/6.0
Review: https://review.openstack.org/338880
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (stable/5.1)

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: stable/5.1
Review: https://review.openstack.org/341486
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.