upstream puppet modules changing way to configure keystone_authtoken parameters

Bug #1600276 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Unassigned

Bug Description

The upstream puppet modules are changing how they define the keystone_authtoken/* configuration items. They have created a a helper resource in puppet-keystone keystone::resource::authtoken to handle the configuration. They are updating the other modules to leverage this and we have conflicts when they do this cutover. We need to update fuel's usage of the upstream modules to work around these efforts.

For example,
puppet-nova: https://review.openstack.org/#/c/337389/
puppet-cinder: https://review.openstack.org/#/c/268634/
puppet-glance: https://review.openstack.org/#/c/268233/

summary: - up
+ upstream puppet modules changing way to configure keystone_authtoken
+ parameters
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-library (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/339721

tags: added: area-puppet
removed: area-library
tags: added: 10.0-reviewed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/340900

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/341501

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/341501
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=1ce9e622fc76cfaeb9736f127365961a050bbccd
Submitter: Jenkins
Branch: master

commit 1ce9e622fc76cfaeb9736f127365961a050bbccd
Author: Maksym Yatsenko <email address hidden>
Date: Wed Jul 13 15:48:15 2016 +0300

    Fix keystone_authtoken middleware for glance

    As PKI tokens are not supported 'signing_dir' was
    removed for glance.

    Change-Id: Ia8c43bc252eaa8d84894a216daa52edb3b8aa797
    Related-Bug: #1600276

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/340900
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=e98016a6c5af3237a8011fcee40907928372dc07
Submitter: Jenkins
Branch: master

commit e98016a6c5af3237a8011fcee40907928372dc07
Author: Maksym Yatsenko <email address hidden>
Date: Tue Jul 12 14:55:40 2016 +0300

    Fix keystone_authtoken middleware for cinder

    As PKI tokens are not supported 'signing_dir' and
    'signing_dirname' were removed for cinder.

    Change-Id: I0db0666aaeaa0f6316d6192868676e1bb73ad352
    Related-Bug: #1600276

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/339721
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=3a263d6b32d9a03f0c62efbf44644aed99b2d64a
Submitter: Jenkins
Branch: master

commit 3a263d6b32d9a03f0c62efbf44644aed99b2d64a
Author: Alex Schultz <email address hidden>
Date: Fri Jul 8 11:05:42 2016 -0600

    Fix keystone_authtoken middleware for nova

    This change removes the signing_dir from the nova configuration as it is
    for PKI tokens which are no longer supported. Additionally, the
    keystone_authtoken/memcached_servers should be configured only for the
    api services.

    Change-Id: I35b91b4fe65d79a5cd4ed81a584d67a97a1e21d5
    Related-Bug: #1600276

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-library (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/346964

Changed in fuel:
assignee: MOS Puppet Team (mos-puppet) → Alexey Deryugin (velovec)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/356581

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/356583

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/356581
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=19550ea4d703bfd0e5103be7eedc45dd5b8586da
Submitter: Jenkins
Branch: master

commit 19550ea4d703bfd0e5103be7eedc45dd5b8586da
Author: Alexey Deryugin <email address hidden>
Date: Wed Aug 17 19:14:34 2016 +0300

    Fix keystone_authtoken middleware for aodh

    As PKI tokens are not supported 'signing_dir' was
    removed for aodh.

    Change-Id: I794303a427b1b5e3f2d3d0de2a5d56a3e85767be
    Related-Bug: #1600276

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/346964
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=db05ceaa25a29947eccaa78e03e5cac59b030370
Submitter: Jenkins
Branch: master

commit db05ceaa25a29947eccaa78e03e5cac59b030370
Author: Alex Schultz <email address hidden>
Date: Mon Jul 25 11:43:16 2016 -0600

    Noop workaround for keystone_authtoken

    This change comments out the conflicting parameters for the upstream
    change to ceilometer for the keystone_authtoken work.

    https://review.openstack.org/#/c/345789

    Change-Id: Idb84d50a1245c5701d449a4178493fd69a4fc268
    Related-Bug: #1600276

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/356583
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=26c6361e287782bd00ee924b648959e24db49ae6
Submitter: Jenkins
Branch: master

commit 26c6361e287782bd00ee924b648959e24db49ae6
Author: Alexey Deryugin <email address hidden>
Date: Wed Aug 17 19:22:57 2016 +0300

    Fix keystone_authtoken middleware for glance

    We need to resolve conflicts to unlock
    https://review.openstack.org/#/c/348826/

     - Remove conflicting authtoken parameters
     - Temporarily disable noop test

    Change-Id: I2e471cdc2520337921e84035f9a4f0f54adfba07
    Related-Bug: #1600276

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-library (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/362765

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/362765
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=e58b5df42dc512dffee4f61a36a7e6ec61a9d553
Submitter: Jenkins
Branch: master

commit e58b5df42dc512dffee4f61a36a7e6ec61a9d553
Author: Alexey Deryugin <email address hidden>
Date: Tue Aug 30 13:27:05 2016 +0300

    Disable noop tests for old parameters for puppet-nova

    Temporarily disable some noop tests to
    unlock https://review.openstack.org/#/c/361906/

    Change-Id: I216ce5a19cce503678362f81a12acdf27627943d
    Related-Bug: #1600276

Changed in fuel:
assignee: Alexey Deryugin (velovec) → nobody
Revision history for this message
Oleksiy Molchanov (omolchanov) wrote :

Can we consider this as Fix Committed?

Revision history for this message
Oleksiy Molchanov (omolchanov) wrote :

Marking as "Fix Committed", seems that all needed patches were applied.

Changed in fuel:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.