Octane VIP copy is broken for 9.0 Fuel

[Vladimir Kuklin]

1. Install 8.0 Fuel Node
2. Install 8.0 BVT_2 cluster
3. Upgrade Fuel node
4. Start upgrade procedure for cluster.

when VIPs are copied, they do not populate required data, such as 'namespace'. This leads to issues in Fuel Library manifests as they get wrong data. For example, external_lb is set to true and haproxy is not properly configured.

========= UPD: how to verify:
You can validate it after the upgrade of primary controller:

    $ octane upgrade-node --isolated <new-env-id> <node-id>
    $ fuel vip --download --env <new-env-id>

and verify the namespace parameter of all VIPs and also check that VIPs are the same as in the original environment:

    $ fuel vip --download --env <orig-env-id>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/350066

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/351659

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/350066
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=5e571d42bec98424f1a2fd7b3e363468124ab94a
Submitter: Jenkins
Branch: stable/mitaka

commit 5e571d42bec98424f1a2fd7b3e363468124ab94a
Author: Nikita Zubkov <email address hidden>
Date: Tue Aug 2 17:23:44 2016 +0300

    Fix assigning of VIPs

    assign_given_vips_for_net_groups now creates IP adresses with
    apropriate namespace and is_user_defined attributes.

    Change-Id: I74527b03deee875d4a3f09535ed14dacf372f577
    Closes-Bug: #1599790

[OpenStack Infra (hudson-openstack)]

Change abandoned by Nikita Zubkov (<email address hidden>) on branch: master
Review: https://review.openstack.org/351659

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/351659
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=37de24e7ec367677aa5d2ab615f097e6b9946ecc
Submitter: Jenkins
Branch: master

commit 37de24e7ec367677aa5d2ab615f097e6b9946ecc
Author: Nikita Zubkov <email address hidden>
Date: Tue Aug 2 17:23:44 2016 +0300

    Fix assigning of VIPs

    assign_given_vips_for_net_groups now creates IP adresses with
    apropriate namespace and is_user_defined attributes.

    Change-Id: I74527b03deee875d4a3f09535ed14dacf372f577
    Closes-Bug: #1599790

[Vladimir Khlyunev (vkhlyunev)]

8-9 cloud upgrade is out of scope right now - and the code can be broken; please point 'when vip should be converted (upgrade step or action or api call etc)

[Ilya Kharin (akscram)]

It affects upgrade on the 9.x releases and the fix already merged in stable/mitaka and master branches. You can validate it after the upgrade of primary controller:

    $ octane upgrade-node --isolated <new-env-id> <node-id>
    $ fuel vip --download --env <new-env-id>

and verify the namespace parameter of all VIPs and also check that VIPs are the same as in the original environment:

    $ fuel vip --download --env <orig-env-id>

[Nikita Zubkov (zubchick)]

the wrong output from get_assigned_vips function.

```
{u'public': {'id': 5,
               'ip_addr': '10.109.4.3',
               'is_user_defined': False,
               'network': 2,
               'network_data': <nailgun.db.sqlalchemy.models.network.NetworkGroup at 0x677e4d0>,
               'node': None,
               'vip_name': u'public',
               'vip_namespace': u'haproxy'},
              u'vrouter_pub': {'id': 4,
               'ip_addr': '10.109.4.2',
               'is_user_defined': False,
               'network': 2,
               'network_data': <nailgun.db.sqlalchemy.models.network.NetworkGroup at 0x677e4d0>,
               'node': None,
               'vip_name': u'vrouter_pub',
               'vip_namespace': u'vrouter'}}
```
network_data should be serialized too.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/364850

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/364863

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/364850
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=08797d3a27c58c493228233c1aeb591c82a4f8b2
Submitter: Jenkins
Branch: master

commit 08797d3a27c58c493228233c1aeb591c82a4f8b2
Author: Nikita Zubkov <email address hidden>
Date: Fri Sep 2 13:00:01 2016 +0300

    Fix vip serialization

    Change-Id: I37ab760b97c0a4fae748a7a7ff55ddcde2f22fd9
    Partial-Bug: #1599790

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/364863
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=499a386189f27a42c6c4bb5f11a4a5f61946bf63
Submitter: Jenkins
Branch: stable/mitaka

commit 499a386189f27a42c6c4bb5f11a4a5f61946bf63
Author: Nikita Zubkov <email address hidden>
Date: Fri Sep 2 13:00:01 2016 +0300

    Fix vip serialization

    Change-Id: I37ab760b97c0a4fae748a7a7ff55ddcde2f22fd9
    Partial-Bug: #1599790
    (cherry picked from commit 08797d3a27c58c493228233c1aeb591c82a4f8b2)

[Vladimir Khlyunev (vkhlyunev)]

snapshot 201

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 10.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 10.0.0 release.