Rewrite the code vcenter_compute_zones.py

Bug #1598440 reported by Andrey Kirilochkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Rodion Tikunov

Bug Description

Please improve this improve

https://github.com/openstack/fuel-library/commit/58bd7bf73e01ff430bcd02381311a6ef4994d480#diff-a3b003a257c7a9d004cc565522075cdeR25

+def get_data_from_hiera(key):
+ cmd = 'ruby -r hiera -r yaml -e \'hiera = Hiera.new(:config => \
+ "/etc/puppet/hiera.yaml"); data = hiera.lookup "'+key+'", \
+ [], {}; puts YAML.dump data\''
+ try:
+ cmd_data = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE)
+ except subprocess.CalledProcessError as err:
+ print("Error code", err.returncode, err.output)
+ sys.exit(1)
+
+ data = yaml.load(cmd_data.stdout.read())
+ return data

We running ruby in python in shell in puppet, something wrong.

+ AUTH_URL = "http://" + IP + ":5000/v2.0/"

Hardcoded auth url value.

Dmitry Pyzhov (dpyzhov)
tags: added: area-partners
Changed in fuel:
milestone: none → 10.0
tags: added: tech-debt
Changed in fuel:
assignee: nobody → Fuel Partner Core (fuel-partner-core)
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Andrey Kirilochkin (andreika-mail) wrote :

Guys, please merge it.
Bugfix: https://review.openstack.org/#/c/379841/

Dmitry Ilyin (idv1985)
Changed in fuel:
milestone: 10.0 → 9.2
importance: Medium → High
Changed in fuel:
assignee: Fuel Partner Core (fuel-partner-core) → Andrey Kirilochkin (andreika-mail)
status: Confirmed → In Progress
Changed in fuel:
importance: High → Medium
Changed in fuel:
assignee: Andrey Kirilochkin (andreika-mail) → Rodion Tikunov (rtikunov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/406842

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/379841
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=d9e0dcefb638be3ac4b46c58efd6f9aa93982a35
Submitter: Jenkins
Branch: master

commit d9e0dcefb638be3ac4b46c58efd6f9aa93982a35
Author: Andrey Kirilochkin <email address hidden>
Date: Thu Sep 29 17:29:01 2016 -0500

    Implemented TLS/SSL support in vcenter_hooks.py

    Closes-bug: #1598440

    Change-Id: I8083676714f58399b1eaed57e73e8f5dfa9b2644

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/newton)

Reviewed: https://review.openstack.org/406842
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=2b4d855856f9965b7faa56b9a8bc9822252c5d42
Submitter: Jenkins
Branch: stable/newton

commit 2b4d855856f9965b7faa56b9a8bc9822252c5d42
Author: Andrey Kirilochkin <email address hidden>
Date: Thu Sep 29 17:29:01 2016 -0500

    Implemented TLS/SSL support in vcenter_hooks.py

    Closes-bug: #1598440

    Change-Id: I8083676714f58399b1eaed57e73e8f5dfa9b2644

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/426186

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-library 11.0.0.0rc1

This issue was fixed in the openstack/fuel-library 11.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (stable/mitaka)

Change abandoned by Andreas Jaeger (<email address hidden>) on branch: stable/mitaka
Review: https://review.opendev.org/426186
Reason: This repo is retired now, no further work will get merged.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.