Wrong haproxy backend status for http provider when got 401 http code

Bug #1597416 reported by Denis Egorenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Denis Egorenko
8.0.x
In Progress
High
Denis Egorenko
Mitaka
Fix Released
High
Denis Egorenko

Bug Description

Http provider for haproxy_backend_status resource returns wrong backend status, when got 401 status code (Unauthorized) from client side [1]. Because of this problem backend status will be switched to down, but in fact backend is ready and up.

[1] https://github.com/openstack/fuel-library/blob/master/deployment/puppet/haproxy/lib/puppet/provider/haproxy_backend_status/http.rb#L23-L24

Deploy detached-haproxy + sahara

Tags: area-library
description: updated
no longer affects: fuel/newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/335575

Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Denis Egorenko (degorenko)
status: Confirmed → In Progress
tags: added: area-library
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/335575
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=7e4afb7a6fe9a335ad0d7b66a6231da1c31599ef
Submitter: Jenkins
Branch: master

commit 7e4afb7a6fe9a335ad0d7b66a6231da1c31599ef
Author: Denis Egorenko <email address hidden>
Date: Wed Jun 29 19:06:02 2016 +0300

    Set haproxy state to up when got 401 error

    Haproxy state should be set to up, when got 401 code from client
    side - Unauthorized - that means that backend is ready and up.

    Change-Id: I65b6e6789ac376a2ba0c95f03f6963fed804ba2d
    Closes-bug: #1597416

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/335898

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/335899

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/mitaka)

Reviewed: https://review.openstack.org/335898
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=6d782f6c0a8372df113c4e5f1a2b3ceb2e37a41c
Submitter: Jenkins
Branch: stable/mitaka

commit 6d782f6c0a8372df113c4e5f1a2b3ceb2e37a41c
Author: Denis Egorenko <email address hidden>
Date: Wed Jun 29 19:06:02 2016 +0300

    Set haproxy state to up when got 401 error

    Haproxy state should be set to up, when got 401 code from client
    side - Unauthorized - that means that backend is ready and up.

    Change-Id: I65b6e6789ac376a2ba0c95f03f6963fed804ba2d
    Closes-bug: #1597416
    (cherry picked from commit 7e4afb7a6fe9a335ad0d7b66a6231da1c31599ef)

tags: added: on-verification
Revision history for this message
Kristina Berezovskaia (kkuznetsova) wrote :

Verify on
CUSTOM_VERSION=snapshot #181
MAGNET_LINK=magnet:?xt=urn:btih:bfec808dd71ff42c5613a3527733d9012bb1fabc&dn=MirantisOpenStack-9.0.iso&tr=http%3A%2F%2Ftracker01-bud.infra.mirantis.net%3A8080%2Fannounce&tr=http%3A%2F%2Ftracker01-scc.infra.mirantis.net%3A8080%2Fannounce&tr=http%3A%2F%2Ftracker01-msk.infra.mirantis.net%3A8080%2Fannounce&ws=http%3A%2F%2Fvault.infra.mirantis.net%2FMirantisOpenStack-9.0.iso
FUEL_QA_COMMIT=40f2dece546dcb8ca8ac72b964559950e98297f4
UBUNTU_MIRROR_ID=ubuntu-2016-08-03-174238
CENTOS_MIRROR_ID=centos-7.2.1511-2016-05-31-083834
MOS_UBUNTU_MIRROR_ID=9.0-2016-08-25-164322
MOS_CENTOS_OS_MIRROR_ID=os-2016-06-23-135731
MOS_CENTOS_PROPOSED_MIRROR_ID=proposed-2016-08-25-154321
MOS_CENTOS_UPDATES_MIRROR_ID=updates-2016-06-23-135916
MOS_CENTOS_HOLDBACK_MIRROR_ID=holdback-2016-06-23-140047
MOS_CENTOS_HOTFIX_MIRROR_ID=hotfix-2016-07-18-162958
MOS_CENTOS_SECURITY_MIRROR_ID=security-2016-06-23-140002

tags: removed: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (stable/8.0)

Change abandoned by Andreas Jaeger (<email address hidden>) on branch: stable/8.0
Review: https://review.opendev.org/335899
Reason: This repo is retired now, no further work will get merged.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.