Tasks from plugins of version 1 and 2 are not executed

Bug #1596928 reported by Georgy Kibardin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Georgy Kibardin
Mitaka
Fix Released
High
Georgy Kibardin

Bug Description

unless propagate_task_deploy attribute is set to true. The problem is that there is no any warning about that.

Step to reproduce:
1. Take https://github.com/openstack/fuel-plugins/tree/master/examples/fuel_plugin_example_v2 as a base
2. Add shell task with "touch /task_has_been_launched" with role '*'
3. Build and install the plugin
4. Perform deployment
5. check /task_has_been_launched file on nodes

Expected:
  File exists
Actual:
  No such file

tags: added: area-python
Changed in fuel:
assignee: nobody → Fuel Sustaining (fuel-sustaining-team)
milestone: none → 10.0
Dmitry Klenov (dklenov)
Changed in fuel:
importance: Undecided → High
status: New → Confirmed
tags: added: area-plugins
Changed in fuel:
status: Confirmed → In Progress
Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Georgy Kibardin (gkibardin)
Revision history for this message
Georgy Kibardin (gkibardin) wrote :

We've discussed a topic and decided the following:
1. Make propagate_task_deploy flag accessible from UI.
2. Add a property to plugins indicating presence of legacy tasks.
3. In UI disallow enabling plugins with legacy tasks unless propagate_task_deploy is on (with appropriate indication of why it cannot be enabled).

tags: added: area-ui
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/337537

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/337537
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=c6a4a08abff9ba9ce80603cb28ac74d13e95c5e2
Submitter: Jenkins
Branch: master

commit c6a4a08abff9ba9ce80603cb28ac74d13e95c5e2
Author: Georgy Kibardin <email address hidden>
Date: Tue Jul 5 11:21:00 2016 +0300

    New contains_legacy_tasks plugin attribute

    In order to warn users about plugin containing legacy tasks which are
    not executed unless propagate_task_deploy cluster attribte is set UI
    need this attribute.

    Change-Id: I024dc20e6e34bd3979fc532cdbd85f77f0bb0a6e
    Partial-Bug: #1596928

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/342731

Changed in fuel:
status: In Progress → Confirmed
assignee: Georgy Kibardin (gkibardin) → Fuel UI Team (fuel-ui)
Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Georgy Kibardin (gkibardin)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/342731
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=4a333ec2da82da268b493eb8bf5f4e595c86f699
Submitter: Jenkins
Branch: master

commit 4a333ec2da82da268b493eb8bf5f4e595c86f699
Author: Georgy Kibardin <email address hidden>
Date: Fri Jul 15 13:42:55 2016 +0300

    Disallow enbling a plugin with legacy tasks

    When plugin contains legacy tasks enabling it makes no effect unless
    propagate_task_deploy attribute is set. The plugin silently does
    nothing. In order to avoid confusion enabling is prohibited explicitly.

    Change-Id: I4acfb24de02ac4a5cfb25e9c8d5a3a03d5b58e77
    Partial-Bug: 1596928

Dmitry Pyzhov (dpyzhov)
tags: added: 9.1-proposed
Changed in fuel:
assignee: Georgy Kibardin (gkibardin) → Fuel UI Team (fuel-ui)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/355345

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (stable/mitaka)

Change abandoned by Georgy Kibardin (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/355345

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/355741

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/355741
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=5437ba81970ede26ea60d11ed9da157b07f6a4b5
Submitter: Jenkins
Branch: stable/mitaka

commit 5437ba81970ede26ea60d11ed9da157b07f6a4b5
Author: Georgy Kibardin <email address hidden>
Date: Tue Aug 16 09:34:33 2016 +0300

    Disallow enbling a plugin with legacy tasks

    When plugin contains legacy tasks enabling it makes no effect unless
    propagate_task_deploy attribute is set. The plugin silently does
    nothing. In order to avoid confusion enabling is prohibited explicitly.

    Partial-Bug: 1596928
    (cherry picked from commit 4a333ec2da82da268b493eb8bf5f4e595c86f699)

    Change-Id: I7f403faa3054a9126c635e3ed0d00d3d22f20c2a

tags: added: in-stable-mitaka
Changed in fuel:
status: In Progress → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/368869

Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Julia Aranovich (jkirnosova)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (master)

Reviewed: https://review.openstack.org/368869
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=8ad3bf1af86d4d9d76b37ecc1acfcea5cb77041b
Submitter: Jenkins
Branch: master

commit 8ad3bf1af86d4d9d76b37ecc1acfcea5cb77041b
Author: Julia Aranovich <email address hidden>
Date: Mon Sep 12 17:06:48 2016 +0300

    Check ability to enable plugin with legacy tasks

    If common.propagate_task_deploy cluster setting is set to True,
    then plugins that contains legacy tasks can not be enabled.

    Partial-Bug: #1596928

    Change-Id: I40027b99e44f9b20061fb95486af6e00a1b7c40a

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/369312

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (stable/mitaka)

Reviewed: https://review.openstack.org/369312
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=d517c80c8f2ef46c8e7856113a5c8ab1f414d610
Submitter: Jenkins
Branch: stable/mitaka

commit d517c80c8f2ef46c8e7856113a5c8ab1f414d610
Author: Julia Aranovich <email address hidden>
Date: Mon Sep 12 17:06:48 2016 +0300

    Check ability to enable plugin with legacy tasks

    If common.propagate_task_deploy cluster setting is set to True,
    then plugins that contains legacy tasks can not be enabled.

    Partial-Bug: #1596928

    Change-Id: I40027b99e44f9b20061fb95486af6e00a1b7c40a

Revision history for this message
Julia Aranovich (jkirnosova) wrote :

UI patches were merged.

tags: removed: area-ui
Changed in fuel:
assignee: Julia Aranovich (jkirnosova) → Georgy Kibardin (gkibardin)
Changed in fuel:
status: In Progress → Confirmed
status: Confirmed → Fix Committed
tags: added: on-verification
Revision history for this message
ElenaRossokhina (esolomina) wrote :

Verified 9.1 snapshot #299

tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.