puppet-openstacklib lint failures

[Alexey Stupnikov]

verify-puppet-modules.lint is failing on empty commit to mos-8.0 branch of puppet-modules/puppet-openstacklib project. No reasonable output is provided, need help.

Example patch: https://review.fuel-infra.org/#/c/22514/

[Dmitry Kaigarodеsev (dkaiharodsev)]

output on Jenkins console for mentioned example:

+ bundle exec rake lint --trace
** Invoke lint (first_time)
** Execute lint
manifests/db/mysql.pp:66:WARNING: class included by relative name
Build step 'Execute shell' marked build as failure
Finished: FAILURE

[Alexey Stupnikov (astupnikov)]

dkaiharodsev, IMO WARNING message is warning you about special conditions and it doesn't break this test.

[Dmitry Kaigarodеsev (dkaiharodsev)]

@astupnikov seems that the bug is not exactly related to ci-team,

all what our does the job - is to run 'puppet-modules-tests/puppet-modules.sh' script,
taken from https://review.fuel-infra.org/tools/puppet-modules-tests repository,
and if exit code of the script is not 0 - the job fails

a list of folks who's in charge of mentioned repository:
https://review.fuel-infra.org/#/admin/groups/81,members

[Alexey Stupnikov (astupnikov)]

Thanks, I will doublecheck everything and transfer the ticket to those group.

[Alexey Stupnikov (astupnikov)]

puppet-lint-absolute_classname-check gem is included in project's Gemfile. This check is failing for a reason, so no problem or bug here, but there is an issue in project itself.

[Alexey Stupnikov (astupnikov)]

Fix: https://review.fuel-infra.org/#/c/22514

[Alexey Stupnikov (astupnikov)]

Setting importance to critical as this bug is a blocker for bug #1537325

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/22514
Submitter: Ivan Berezovskiy <email address hidden>
Branch: mos-8.0

Commit: 1daf1f3b11df0fa5dc2b20a1ef7e64ea6025ab37
Author: Alexey Stupnikov <email address hidden>
Date: Tue Jun 28 08:48:58 2016

To use absolute paths in class requirements

puppet-lint-absolute_classname-check gem is included in Gemfile.
As a result, it is impossible to get successfull lint test results
with current state of manifests/db/mysql.pp file.

Change-Id: I61fb41819bcd6ed3959fcab4f0658c4593f08b44
Closes-bug: #1595622