l23network doesn't work with Puppet3 unless stringify_facts=false is set

[Dmitry Ilyin]

l23network uses "netrings" fact that should be a hash and will fail if this fact is stringified.

Puppet version 3 and below always stringify all the data acquired from the facter. If it returns such structures and hashes and array they will be represented as strings.

Puppet 4 by default does not do this and keep the data structures in facts so they are accessible from the manifests. Puppet 3 can do the same if
stringify_facts=false is added to the config file. In Fuel we have this
variable so the facts are working as intended, but this situation can be problematic if the module is used outside of Fuel.

There should be at least validation to catch the situation when the string have been passed instead of the data structure, or, even better, the data
structure can be dumped into a JSON or YAML and the parsed again the the manifest and if have been doing in the previous versions of Puppet.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/332178

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/332178
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=251bc08af6323e91a7483b435d2902e10345ac70
Submitter: Jenkins
Branch: master

commit 251bc08af6323e91a7483b435d2902e10345ac70
Author: Dmitry Ilyin <email address hidden>
Date: Tue Jun 21 17:41:35 2016 +0300

    Add checks if the "netrings" fact is a Hash

    * It will be stringified unless stringification
      is disabled in the puppet config.

    Change-Id: I540a3bc6b9402c14c4467b97f4eb29bfabfb8e07
    Related-Bug: 1594843