Nailgun unavailability dialog disappears right after appearance

Bug #1592788 reported by Vitaly Kramskikh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Vitaly Kramskikh

Bug Description

After upgrading jQuery to v3, this dialog is not visible anymore. Probably it's related to changes in jQuery Promises.

Revision history for this message
Bug Checker Bot (bug-checker) wrote : Autochecker

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

tags: added: need-info
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/331109

Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Vitaly Kramskikh (vkramskikh)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (master)

Reviewed: https://review.openstack.org/331109
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=5c0259e946dbed734b3bdf16727234c906c19182
Submitter: Jenkins
Branch: master

commit 5c0259e946dbed734b3bdf16727234c906c19182
Author: Vitaly Kramskikh <email address hidden>
Date: Fri Jun 17 13:11:04 2016 +0300

    Fix Nailgun unavailability dialog

    It was broken after upgrading jQuery to v3. It happend due to
    backwards-incompatible changes in deferreds handling:

    The resolution state of a Deferred created by .then() is now
    controlled by its callbacks - exceptions become rejection
    values and non-thenable returns become fulfillment values.
    Previously, returns from rejection handlers became rejection
    values.

    Now it's required to explicitly return rejected promise from
    rejection handler in app bootstrap promise chain.

    Closes-Bug: #1592788

    Change-Id: I2f1512fb421109bb9bc5063b7a314f5d53e16b1d

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.