Nauilgun agent doesn't work with vlan subinterfaces on the bridge interface

Bug #1592361 reported by Vasyl Saienko on 2016-06-14
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
High
Vasyl Saienko
Mitaka
High
Dmitry Pyzhov

Bug Description

ohai reports interface name "br-bm.755@br-bm" for vlan subinterface on the bridge. It leads nailgun agent to fail with the following error:

E, [2016-06-14T08:59:46.180094 #15079] ERROR -- : Error 'No such file or directory - /sys/class/net/br-bm.755@br-bm' in gathering interfaces metadata: ["/usr/bin/nailgun-agent:|
409:in `realpath'", "/usr/bin/nailgun-agent:409:in `realpath'", "/usr/bin/nailgun-agent:409:in `block in _detailed'", "/usr/bin/nailgun-agent:402:in `each'", "/usr/bin/nailgun-|
agent:402:in `_detailed'", "/usr/bin/nailgun-agent:985:in `_data'", "/usr/bin/nailgun-agent:216:in `put'", "/usr/bin/nailgun-agent:1191:in `<main>'"]

Vasyl Saienko (vsaienko) on 2016-06-14
description: updated
Changed in fuel:
milestone: none → 10.0

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

tags: added: need-info

Fix proposed to branch: master
Review: https://review.openstack.org/329375

Changed in fuel:
assignee: nobody → Vasyl Saienko (vsaienko)
status: New → In Progress
Vasyl Saienko (vsaienko) on 2016-06-14
description: updated
Dina Belova (dbelova) on 2016-06-15
Changed in fuel:
importance: Undecided → High

Reviewed: https://review.openstack.org/329375
Committed: https://git.openstack.org/cgit/openstack/fuel-nailgun-agent/commit/?id=46c31195d247763aee8916769441339174980a94
Submitter: Jenkins
Branch: master

commit 46c31195d247763aee8916769441339174980a94
Author: Vasyl Saienko <email address hidden>
Date: Tue Jun 14 14:06:48 2016 +0300

    Ignore interfaces with @ in the name

    ohai reports interface name as br-bm.755@br-bm if device is vlan subinterface
    on the bridge.
    This patch skip interfaces with such names.

    Change-Id: I17fe2276ca5e6cddd38f70f44f1275eb97814a26
    Closes-Bug: #1592361

Changed in fuel:
status: In Progress → Fix Committed

This issue was fixed in the openstack/fuel-nailgun-agent 10.0.0rc1 release candidate.

This issue was fixed in the openstack/fuel-nailgun-agent 10.0.0 release.

Alexander Rubtsov (arubtsov) wrote :

We have a customer who hit this bug in MOS 9
Could you please make a backport of the fix?

tags: added: customer-found sla1
Alexander Rubtsov (arubtsov) wrote :

sla1 for 9.0-updates

Reviewed: https://review.openstack.org/418417
Committed: https://git.openstack.org/cgit/openstack/fuel-nailgun-agent/commit/?id=79417d9fba1db2cda0499e09e7cb81820d1d4784
Submitter: Jenkins
Branch: stable/mitaka

commit 79417d9fba1db2cda0499e09e7cb81820d1d4784
Author: Vasyl Saienko <email address hidden>
Date: Tue Jun 14 14:06:48 2016 +0300

    Ignore interfaces with @ in the name

    ohai reports interface name as br-bm.755@br-bm if device is vlan subinterface
    on the bridge.
    This patch skip interfaces with such names.

    Change-Id: I17fe2276ca5e6cddd38f70f44f1275eb97814a26
    Closes-Bug: #1592361
    (cherry picked from commit 46c31195d247763aee8916769441339174980a94)

tags: added: on-verification
Ilya Bumarskov (ibumarskov) wrote :
Download full text (4.0 KiB)

Verified on snapshot-id 822.

Steps to verify:
1) Change interface name for node:
root@bootstrap:~# ip link
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: enp0s3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
    link/ether 64:1b:fd:10:0e:7f brd ff:ff:ff:ff:ff:ff
3: enp0s4: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/ether 64:6e:c5:9f:a6:8a brd ff:ff:ff:ff:ff:ff
4: enp0s5: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/ether 64:09:e6:fa:8f:76 brd ff:ff:ff:ff:ff:ff
5: enp0s6: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/ether 64:9f:55:74:9b:a0 brd ff:ff:ff:ff:ff:ff
6: enp0s7: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/ether 64:36:bf:44:66:dc brd ff:ff:ff:ff:ff:ff
root@bootstrap:~#
root@bootstrap:~# ip link set enp0s4 name enp0s4.0
root@bootstrap:~# ip link
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: enp0s3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
    link/ether 64:1b:fd:10:0e:7f brd ff:ff:ff:ff:ff:ff
3: enp0s4.0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/ether 64:6e:c5:9f:a6:8a brd ff:ff:ff:ff:ff:ff
4: enp0s5: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/ether 64:09:e6:fa:8f:76 brd ff:ff:ff:ff:ff:ff
5: enp0s6: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/ether 64:9f:55:74:9b:a0 brd ff:ff:ff:ff:ff:ff
6: enp0s7: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/ether 64:36:bf:44:66:dc brd ff:ff:ff:ff:ff:ff

2) Check that nailgun refresh the interface attributes:
[root@nailgun ~]# fuel2 node interfaces download -f json 1 && cat /root/node_1/interfaces.json | grep enp
Configuration of interfaces for node with id 1 was stored in /root/node_1/interfaces.json
        "name": "enp0s3",
        "name": "enp0s4.0",
        "name": "enp0s5",
        "name": "enp0s6",
        "name": "enp0s7",

3) Set interface name with '@'
root@bootstrap:~# ip link set enp0s4.0 name enp0s4.0@enp
root@bootstrap:~# ip link
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: enp0s3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
    link/ether 64:1b:fd:10:0e:7f brd ff:ff:ff:ff:ff:ff
3: enp0s4.0@enp: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/ether 64:6e:c5:9f:a6:8a brd ff:ff:ff:ff:ff:ff
4: enp0s5: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group ...

Read more...

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers