[Gerrit] NACR is not set

[Ivan Udovichenko]

For some reason Non-Author-Code-Review can't be set, even after 2 non-author reviews:
https://review.fuel-infra.org/#/c/21678/

Project: openstack-build/oslo.concurrency-build

[Andrey Nikitin (heos)]

Ivan, as workaround: try to create another request and upload the code. I'm not sure, but I think, it should helps you.

[Ivan Udovichenko (iudovichenko)]

It has happened again:
https://review.fuel-infra.org/#/c/22359/

[Ivan Udovichenko (iudovichenko)]

And request was not merged even after set Verified (+2):
https://review.fuel-infra.org/#/c/21678/
Anyway this ^^^ particular requests we don't need anymore.

We need just this one:
https://review.fuel-infra.org/#/c/22359/

Which will unblock our further work on packages.

[Andrey Nikitin (heos)]

The root cause of the bug is incorrect rules in NACR-related file.

That file had the following rule "gerrit:commit_label(label('Code-Review', 1), R)," in line 9 instead of "gerrit:commit_label(label('Code-Review', 2), R),".

The first rule means, that a request should has one CR+1, as minimum, to allow merge it with a lot of CR+2 scores.

I've updated the rules.pl file with proper rule.

Please check and let me know, if you will have a problem with merging.