'fuel2 task history' shows extra tasks

[ElenaRossokhina]

'fuel2 task history' shows extra tasks
Detailed bug description:
[root@nailgun ~]# fuel2 task history show 6 --tasks-names hiera mongo
+-----------+---------+---------+----------------------------+----------------------------+
| task_name | node_id | status | time_start | time_end |
+-----------+---------+---------+----------------------------+----------------------------+
| hiera | 1 | ready | 2016-06-09T14:05:57.808171 | 2016-06-09T14:05:59.976000 |
| hiera | 3 | ready | 2016-06-09T14:05:57.857852 | 2016-06-09T14:06:00.128466 |
| hiera | 2 | ready | 2016-06-09T14:05:57.915096 | 2016-06-09T14:06:00.289459 |
| hiera | 5 | ready | 2016-06-09T14:05:57.961197 | 2016-06-09T14:06:00.486337 |
| hiera | 7 | ready | 2016-06-09T14:05:58.045787 | 2016-06-09T14:06:00.846603 |
| hiera | 6 | ready | 2016-06-09T14:05:58.087145 | 2016-06-09T14:06:00.986072 |
| hiera | 4 | ready | 2016-06-09T14:05:58.002661 | 2016-06-09T14:06:00.679847 |
| mongo | None | skipped | None | None |
+-----------+---------+---------+----------------------------+----------------------------+
[root@nailgun ~]# fuel2 task history show 6 --tasks-names hiera mongo base-os --statuses skipped
+-----------+---------+---------+------------+----------+
| task_name | node_id | status | time_start | time_end |
+-----------+---------+---------+------------+----------+
| hiera | None | skipped | None | None |
| mongo | None | skipped | None | None |
| base-os | None | skipped | None | None |
+-----------+---------+---------+------------+----------+

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 458
cat /etc/fuel_build_number:
 458
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6349.noarch
 fuel-misc-9.0.0-1.mos8449.noarch
 python-packetary-9.0.0-1.mos140.noarch
 fuel-bootstrap-cli-9.0.0-1.mos285.noarch
 fuel-migrate-9.0.0-1.mos8449.noarch
 rubygem-astute-9.0.0-1.mos750.noarch
 fuel-mirror-9.0.0-1.mos140.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-openstack-metadata-9.0.0-1.mos8741.noarch
 fuel-notify-9.0.0-1.mos8449.noarch
 nailgun-mcagents-9.0.0-1.mos750.noarch
 python-fuelclient-9.0.0-1.mos325.noarch
 fuel-9.0.0-1.mos6349.noarch
 fuel-utils-9.0.0-1.mos8449.noarch
 fuel-setup-9.0.0-1.mos6349.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8741.noarch
 fuel-library9.0-9.0.0-1.mos8449.noarch
 network-checker-9.0.0-1.mos74.x86_64
 fuel-agent-9.0.0-1.mos285.noarch
 fuel-ui-9.0.0-1.mos2717.noarch
 fuel-ostf-9.0.0-1.mos935.noarch
 fuelmenu-9.0.0-1.mos273.noarch
 fuel-nailgun-9.0.0-1.mos8741.noarch
[root@nailgun ~]#

Env is still available

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/328258

[ElenaRossokhina (esolomina)]

How to verify:
0. Deploy any cluster, for example 1 controller + 1 compute, all default settings
It is necessary to check node`s filtering works correctly:
1. Run fuel2 task history show 6 --tasks-names <specify at least two tasks for different nodes> --debug --show-parameters
Check tasks are displayed correctly
2. Run fuel2 task history show 6 --tasks-names <specify at least two tasks for different nodes> -- nodes <node-id> --debug --show-parameters
Check filtering: no "None" nodes in output.
One more example of wrong output is attached.

[Vladimir Kuklin (vkuklin)]

There is a workaround ot filter things out properly

for fuel CLI v1 use the following awk filter:

... | awk -F '|' '{if (!match($2,/^[[:space:]]*$/,result)) { print $result[0] } }'

for fuel CLI v2 use the other one:

... | awk -F '|' '{if (!match($3,/None/,result)) { print $result[0] } }'

[Vladimir Kuklin (vkuklin)]

I changed bug priority as it is a flaw in one of the main features of the release which impacts UX very negatively.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/328258
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=09a475ad8fbeda615cc5cfde79fa48fd15105794
Submitter: Jenkins
Branch: master

commit 09a475ad8fbeda615cc5cfde79fa48fd15105794
Author: Ilya Kutukov <email address hidden>
Date: Fri Jun 10 15:02:15 2016 +0300

    Now surrogate deployment history tasks respecting filtering

    Before when we filter out deployment tasks history all the difference
    between tasks graph snapshot and filter result was returned as surrogate tasks
    with no run name and node.
    The deployment tasks history is saved for dry run as well.

    Change-Id: I39a3341230a00aa53fa3a4cba31ee0aacb0ec2ae
    Closes-Bug: #1590872

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/344330

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/344330
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=03cc4ea00c2404487d9aa83553e8a5c0f763537b
Submitter: Jenkins
Branch: stable/mitaka

commit 03cc4ea00c2404487d9aa83553e8a5c0f763537b
Author: Ilya Kutukov <email address hidden>
Date: Tue Jul 19 18:40:43 2016 +0300

    Now surrogate deployment history tasks respecting filtering

    Before when we filter out deployment tasks history all the difference
    between tasks graph snapshot and filter result was returned as surrogate tasks
    with no run name and node.
    The deployment tasks history is saved for dry run as well.

    Change-Id: I39a3341230a00aa53fa3a4cba31ee0aacb0ec2ae
    Closes-Bug: #1590872

[Dmitry Belyaninov (dbelyaninov)]

http://paste.openstack.org/show/564547/

There is difference for hiera task on outputs (see initial descripton).

[Dmitry Belyaninov (dbelyaninov)]

Reverified on snapshot #266