master.fuel-nailgun-agent.pkgs.ubuntu.review_nailgun_agent_one_node failed on checking package sha

[Artem Hrechanychenko]

Detailed bug description:
 Traceback (most recent call last):
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/master.fuel-nailgun-agent.pkgs.ubuntu.review_nailgun_agent_one_node/fuel-qa/fuelweb_test/helpers/decorators.py", line 121, in wrapper
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/master.fuel-nailgun-agent.pkgs.ubuntu.review_nailgun_agent_one_node/fuel-qa/gates_tests/tests/test_nailgun_agent.py", line 58, in gate_patch_nailgun_agent
    inject_nailgun_agent_ubuntu_bootstrap(self.env)
  File "/home/jenkins/workspace/master.fuel-nailgun-agent.pkgs.ubuntu.review_nailgun_agent_one_node/fuel-qa/gates_tests/helpers/utils.py", line 319, in inject_nailgun_agent_ubuntu_bootstrap
    assert_equal(new_sum != old_sum, True)
AssertionError: False != True

Steps to reproduce:
 -
Expected results:
 -
Actual result:
 -
Reproducibility:
 https://ci.fuel-infra.org/job/master.fuel-nailgun-agent.pkgs.ubuntu.review_nailgun_agent_one_node/2/console

Workaround:
 -
Impact:
 -
Description of the environment:
 -

[Artem Hrechanychenko (agrechanichenko)]

reason of failure - package already injected in ubuntu bootstrap when master node was installed.

So we cannot skip UPDATE_FUEL=True , because upload_rpm_method will be failed with trace - because it's method required this flag.

So need to add checking which will check version of nailgun-agent injected in ubuntu bootstrap - and if version from review already installed - skip injecting process

[Artem Hrechanychenko (agrechanichenko)]

Update:

as we have method to update fuel-boostrap-cli.yaml and check_package_version injected in bootstrap - need to remove two method from test - upload_nailgun_agent_rpm() and inject_nailgun_agent and refactor this test with new methods

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/327071

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/327228

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/327071
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=d3f262c368c76ec3d8bc28bc8da0940029ab7dd6
Submitter: Jenkins
Branch: master

commit d3f262c368c76ec3d8bc28bc8da0940029ab7dd6
Author: Artem Grechanichenko <email address hidden>
Date: Wed Jun 8 15:46:15 2016 +0300

    Refactor test_nailgun_agent

    1)As we have method for rebuilding bootstrap with packages from review
    so no needed upload this package to master node and rebuild boostrap manually
    and manually updating nailgun agent
    2) moved update_bootstrap_cli_yaml to helpers/utils
    3) removed not needed methods

    Change-Id: I42008d795fc2875386144c10ec557ccc8e25df49
    Closes-Bug: #1590331

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/327228
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=ab065f12f40b64284030f37506dda9b0ae0c4df5
Submitter: Jenkins
Branch: stable/mitaka

commit ab065f12f40b64284030f37506dda9b0ae0c4df5
Author: Artem Grechanichenko <email address hidden>
Date: Wed Jun 8 15:46:15 2016 +0300

    Refactor test_nailgun_agent

    1)As we have method for rebuilding bootstrap with packages from review
    so no needed upload this package to master node and rebuild boostrap manually
    and manually updating nailgun agent
    2) moved update_bootstrap_cli_yaml to helpers/utils
    3) removed not needed methods

    Change-Id: I42008d795fc2875386144c10ec557ccc8e25df49
    Closes-Bug: #1590331

[Artem Hrechanychenko (agrechanichenko)]

Looks like no failures in last master/mitaka jobs so move to Fix-Released