[LCM] 'logging' task is not idempotent

[Dmitriy Kruglov]

Steps to reproduce:
 1. Deploy a simple env, e.g. 1 controller + 1 compute
 2. Rerun task "logging" against a node

 # Via Fuel CLI
 > fuel node --node-id <node_id> --tasks logging
 # or the direct run of the corresponding puppet manifest on a node
 > puppet apply --noop /etc/puppet/modules/osnailyfacter/modular/logging/logging.pp

Expected result: no resources are changed.
Actual result: some resources are changed.

Below is the trace of task dry run:
Notice: Scope(Class[Osnailyfacter::Logging::Logging]): MODULAR: logging/logging.pp
Notice: Compiled catalog for node-3.test.domain.local in environment production in 0.93 seconds
Notice: /Stage[main]/Rsyslog::Install/Package[rsyslog-relp]/ensure: current_value purged, should be latest (noop)
Notice: /Stage[main]/Rsyslog::Install/Package[rsyslog-gnutls]/ensure: current_value purged, should be latest (noop)
Notice: Class[Rsyslog::Install]: Would have triggered 'refresh' from 2 events
Notice: Class[Rsyslog::Service]: Would have triggered 'refresh' from 2 events
Notice: /Stage[main]/Rsyslog::Service/Service[rsyslog]: Would have triggered 'refresh' from 1 events
Notice: Class[Rsyslog::Service]: Would have triggered 'refresh' from 1 events
Notice: Stage[main]: Would have triggered 'refresh' from 2 events
Notice: Finished catalog run in 0.49 seconds

Description of the environment:
MOS 9.0, ISO build 448.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/327155

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326604
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=258166744ab185e125e4a7a141c8ffd13d512644
Submitter: Jenkins
Branch: master

commit 258166744ab185e125e4a7a141c8ffd13d512644
Author: Dmitry Ilyin <email address hidden>
Date: Tue Jun 7 19:01:52 2016 +0300

    Fix the apt_fuel provider

    * Update method is used for 'latest' implementation
      and may not be overrided.

    Closes-Bug: 1589884

    Change-Id: Ie5529cd62263b97a7f210901e1166698d92d869a
    Signed-off-by: Sergii Golovatiuk <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/327155
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=6d3620f7c19497b5a7cc950687b60590c8925d93
Submitter: Jenkins
Branch: stable/mitaka

commit 6d3620f7c19497b5a7cc950687b60590c8925d93
Author: Dmitry Ilyin <email address hidden>
Date: Tue Jun 7 19:01:52 2016 +0300

    Fix the apt_fuel provider

    * Update method is used for 'latest' implementation
      and may not be overrided.

    Closes-Bug: 1589884

    Change-Id: Ie5529cd62263b97a7f210901e1166698d92d869a
    Signed-off-by: Sergii Golovatiuk <email address hidden>
    (cherry picked from commit 258166744ab185e125e4a7a141c8ffd13d512644)

[Dmitriy Kruglov (dkruglov)]

Verified on MOS 9.0, ISO build 460.
The issue is fixed.

ISO details:
[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 460
cat /etc/fuel_build_number:
 460
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6349.noarch
 python-packetary-9.0.0-1.mos140.noarch
 fuel-bootstrap-cli-9.0.0-1.mos285.noarch
 fuel-migrate-9.0.0-1.mos8450.noarch
 rubygem-astute-9.0.0-1.mos750.noarch
 fuel-mirror-9.0.0-1.mos140.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-openstack-metadata-9.0.0-1.mos8741.noarch
 fuel-notify-9.0.0-1.mos8450.noarch
 nailgun-mcagents-9.0.0-1.mos750.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8741.noarch
 python-fuelclient-9.0.0-1.mos325.noarch
 fuel-9.0.0-1.mos6349.noarch
 fuel-utils-9.0.0-1.mos8450.noarch
 fuel-setup-9.0.0-1.mos6349.noarch
 fuel-misc-9.0.0-1.mos8450.noarch
 fuel-library9.0-9.0.0-1.mos8450.noarch
 network-checker-9.0.0-1.mos74.x86_64
 fuel-agent-9.0.0-1.mos285.noarch
 fuel-ui-9.0.0-1.mos2717.noarch
 fuel-ostf-9.0.0-1.mos935.noarch
 fuelmenu-9.0.0-1.mos273.noarch
 fuel-nailgun-9.0.0-1.mos8741.noarch