Fuel library doesn't update DNS server in case of 'save-only' mode

[Alisa Tselovalnikova]

Detailed bug description:
 By default value '8.8.8.8' propagates as nameserver to FM kernel string and obtains by anaconda. Anaconda set this option as 'DNS1' in interface's up/down script. We are passing configuration of network using fuelmenu cause we set 'false' value for 'show_fuelmenu' option. Host puppet manifest are not touching configuring of network interfaces at all(it configures DNS nameservers in other place). So, we have this 'DNS1=8.8.8.8.' in our interface configuration. This nameserver from interface's configuration will be obtained by up/down network scripts and will be set as first nameserver in '/etc/resolv.conf' file during the network restart or node's reboot. It will lead to unavailability of mirantis resources from fuel node(by name I mean). In our case fuel master has been failed to resolve repository name after the reboot.

Steps to reproduce:
 1. Deploy master with using fuel-qa
 2. Create cluster
 3. Add 3 nodes
 4. Restart fuel master
 5. Run network check

Expected results:
 The network check passed
Actual result:
 The network check failed due to unavailability of mirantis repos

Reproducibility:
 100%

Description of the environment:
 fuel 10.0 iso #288

This issue affects acceptance testing of fuel migration feature on the virtual labs

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/334045

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/334045
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=48754942251c1286a50dcd27b8e67ec585177323
Submitter: Jenkins
Branch: master

commit 48754942251c1286a50dcd27b8e67ec585177323
Author: Maksim Malchuk <email address hidden>
Date: Fri Jun 24 21:37:09 2016 +0300

    Cleanup orphaned dns settings from ifcfg-e* files

    Even if we modify /etc/resolv.conf during the Fuel master node
    installation the file can be changed on reboot with settings left
    after first configuration by NetworkManager.

    Change-Id: I07732dc23bc219b10d41123dd1f47107189f9f8e
    Closes-Bug: #1589469
    Signed-off-by: Maksim Malchuk <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/335408

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/335408
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=db42b86e7766346dfdce6b54be93f924e66f7bff
Submitter: Jenkins
Branch: stable/mitaka

commit db42b86e7766346dfdce6b54be93f924e66f7bff
Author: Maksim Malchuk <email address hidden>
Date: Fri Jun 24 21:37:09 2016 +0300

    Cleanup orphaned dns settings from ifcfg-e* files

    Even if we modify /etc/resolv.conf during the Fuel master node
    installation the file can be changed on reboot with settings left
    after first configuration by NetworkManager.

    Change-Id: I07732dc23bc219b10d41123dd1f47107189f9f8e
    Closes-Bug: #1589469
    Signed-off-by: Maksim Malchuk <email address hidden>
    (cherry picked from commit 48754942251c1286a50dcd27b8e67ec585177323)

[Tatyana Kuterina (tkuterina)]

Verified on 9.1 snapshot #60

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 495
cat /etc/fuel_build_number:
 495
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0