[octane] Octane reports errors partly when calls fuel2 client

[Pavel Chechetin]

Detailed bug description:
  When octane communicate with Nailgun using fuel2 client it doesn't report full error message.
  It turns out when fuel2 client called without --debug and an error occurs the error message is meaningless, but with ---debug it is much helpful.

Steps to reproduce:
  To reproduce this issue make sure that fuel2 client command, which will be called by Octane, fail e.g. provide error state for node which will be undergoing upgrade after.
  octane upgrade-node 2 11

Expected results:
   Console output should contain:
     * Man readable description about what went wrong
     * Fuel2 client arguments

Actual result:
  Console output:
    octane.util.subprocess fuel2[9504] stderr: 400 Client Error: Bad Request
    octane.util.subprocess Process fuel2 finished with return value 1

Reproducibility:
 Always

Impact:
 It slows down troubleshooting

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/325504

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/325504
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=603e028b5ff7bdaf03b38a3ff931c91b885a90a2
Submitter: Jenkins
Branch: master

commit 603e028b5ff7bdaf03b38a3ff931c91b885a90a2
Author: Pavel Chechetin <email address hidden>
Date: Fri Jun 3 18:03:44 2016 +0300

    Extract fuel2 client calling to separate function

      Also --debug flag has been added for more meaningful error reporting.
      Without --debug flag fuel2 client doesn't provide full error messsage
      in case of error.

    Closes-Bug: 1588955
    Change-Id: I53873fdb745d7cc368040a72496f7ccfa5e3a8b4

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/351721

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ilya Kharin (<email address hidden>) on branch: master
Review: https://review.openstack.org/351721
Reason: This patch have to go in stable/mitaka instead of master.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/351728

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/351728
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=3101bf302ea0f2d501fd42a6ae6046c3587ac093
Submitter: Jenkins
Branch: stable/mitaka

commit a05d2ecf13e15c12f10e1517fae425e583e0d714
Author: Nikita Zubkov <email address hidden>
Date: Thu Aug 4 17:51:56 2016 +0300

    fix ssh connection auth

    According to spec [1] service user must use key authentication​ for ssh

    [1] https://github.com/openstack/fuel-specs/blame/ba4504/specs/9.0/fuel-nonroot-openstack-nodes.rst#L61-L64

    Change-Id: I461f659d4f0985283a43ec6a702bdd78af91a072

commit 7140398e501879a4e1f5605f3d1cc99195464850
Author: Sergey Abramov <email address hidden>
Date: Tue Aug 2 12:12:57 2016 +0300

    Setup upgrade levels for each fuel version

    Setup upgrade levels block in nova.conf for each fuel version,
    this is required for backward compatibility on RPC.

    Change-Id: I6ccbc34457d11616b015cdb1e46e733b0b49ce58

commit 9e2a419ac79ad591faee9afe16419bf4497eacad
Author: Vladimir Khlyunev <email address hidden>
Date: Mon Aug 1 21:31:56 2016 +0300

    Fix several typos

    Copypasting is evil, lets remove typos

    Change-Id: Icf4bec1a3de954911a469fa98380af2b6175da08

commit 013a7ded2275245a38ee58289dac2bc8b90fa37e
Author: Sergey Abramov <email address hidden>
Date: Wed Jul 20 16:05:10 2016 +0300

    Host evacuation using nova

    Evacuate instance from compute node using
    nova host-evacuate-live except host_evacuation.sh script

    Change-Id: I01a04cfa1ed2aafce7987e523e6b589dea21fbb0

commit 00a1d0dce1f7ae5db6706a59353403516f7913dc
Author: Sergey Abramov <email address hidden>
Date: Tue Jul 19 17:10:44 2016 +0300

    Change shutoff vm command

    * run nova commands using nova util function
    * host filter using get nova node handle method(
        hostname for fuel < 6.1 and fqdn for newer version)

    Change-Id: Ib5c373714e359982b13910a225787167db7b35e9

commit 49357c98313c5f551b13d0877581c5fb5e108db1
Author: Nikita Zubkov <email address hidden>
Date: Mon Jun 27 18:40:13 2016 +0300

    Add `stderr_log_level` parameter to popen

    Now posible to set logging level in popen for logging stderr

    fuel-bootstrap build comand stderr now logged with INFO level

    Change-Id: Ibaa2be54c68ce7a428e07052c917f54e99b95a5e

commit fb582b271dab4bdd10d27149a77c0e1f6a580b9e
Author: Sergey Abramov <email address hidden>
Date: Thu Jul 21 17:56:41 2016 +0300

    Add run_nova_cmd function

    This is required for running nova command on contoller without
    manipulating manipulating with command.

    It makes code easier and more readable

    Usage:

        from fuelclient.objects import environment as environment_obj

        from octane.util import env
        from octane.util import nova

        env_id = ...
        my_env = environment_obj.Environment(env_id)
        controller = env.get_one_controller(my_env)
        nova_cmd_just_run = [...]
        nova_cmd_with_output = [...]
        nova.run_nova_cmd(nova_cmd_just_run, controller, False)
        result = nova.run_nova_cmd(nova_cmd_w...

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-octane ocata-eol release.